Hi,

I see two patterns which I believe could be improved to save everybody's
(!) time.

Two suggestions:
a) Skip creating PRs if you merge them immediately anyway. It just makes no
sense to create a PR and merge it immediately.
Fake PRs trigger notifications that clutter the mailbox.

b) Follow Git recommendation on having a short and concise commit headline.

See https://git-scm.com/docs/git-commit#_discussion
> Begin the commit message with a single short (less than 50 character)
line summarizing the change, followed by a blank line and then a more
thorough description

PostgreSQL is a nice example for writing concise and helpful commit
messages: https://github.com/postgres/postgres/commits/master
The headline nails the problem, and the commit message elaborates quite
well.

c) I would suggest deleting xslt3 branch from xalan-java repository and
using a single long-lived PR instead.
It would allow us to monitor progress, discuss the changes, and unsubscribe
from all xslt3 notifications at once.

---

With the current state of affairs, "closed PRs" become useless quite fast:
https://github.com/apache/xalan-java/pulls?q=is%3Apr+is%3Aclosed

1) mukulga opens a PR and merges it within a couple of seconds.

If a review is expected from someone, then the PR should be open at least
for several days.
If a review is not expected, then, well, just commit to the branch and be
done with it.

2) The commit messages are too chatty, and it is hard to grasp the core of
the changes.
For example: "improving xalanj implementation on this dev repos branch,
where now xpath 3.1 inline function expressions within their function body,
can call stylesheet 'xsl:function' functions. committing few new related
working test cases as well. also doing minor refactoring of xslt 3.0 test
suite on this xalanj dev repos branch, and few other minor codebase
enhancements as well."

It comes from https://github.com/apache/xalan-java/pull/104

As mukulga writes very long descriptions on the first (and the only)
message line, the history becomes hard to read.

I suggest dropping obvious things like "committing few new related working
test cases as well" at least on the first commit line.
"also doing minor refactoring of xslt 3.0 test suite on this xalanj dev
repos branch, and few other minor codebase enhancements as well" does not
add much information either.
Of course, you always perform "minor codebase
enhancements/refactorings/cleanups". There's no reason to append it to
every commit message.

The above 370 char message "improving xalanj implem..." could better be 94
char "Support calling stylesheet 'xsl:function' functions from xpath 3.1
inline function expressions".

3) The history on xalan-j_xslt3.0 is hard to understand. The branch
contains ~100 merge commits and ~100 "merge" commits.
Try opening gitk origin/xalan-j_xslt3.0.
What is the use of all that?

Vladimir

Reply via email to