vlsi commented on PR #1: URL: https://github.com/apache/xalan-java/pull/1#issuecomment-1770219186
@jkesselm , unfortunately, by closing the PRs you effectively decline the contribution which is demotivating. As you implement the same thing on your own, you effectively steal the contribution and put your name on it. Of course, a single line is not a big deal, however, the change was perfectly valid, it was helpful for many people, so why not just merge it directly? I suggest reconsidering and merging the suggestion instead. It would result in showing carlosame among the contributors (e.g. https://github.com/apache/xalan-java/graphs/contributors ), and it would encourage the others. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
