vlsi commented on PR #105:
URL: https://github.com/apache/xalan-java/pull/105#issuecomment-1774580602

   >If so, I will probably close this PR and open a new on
   
   Why split the history/discussion across several PRs?
   
   > if the user wants to open them up further they can do so, but unnecessary 
execute permissions are asking for trouble.
   
   If you feel the scripts are unsafe, just remove them from the repository.
   If you feel the scripts are ok, then assign the proper execute bits.
   
   Windows does not ask for execute bits, so you make the life of Linux/macOS 
users harder for no reason as you remove the execute bits.
   
   ---
   
   I guess you need to settle on `xalan2jtaglet.jar`. You both move 
xalan2jtaglet.jar to various locations, and add decompiled sources at the same 
time.
   
   > Testing is in progress
   
   I've no idea how you test, however, I hope you'll add CI sooner rather than 
later.
   
   ---
   
   I guess you should not put `package.xhtml` into `site` as `package.html` is 
`javadoc`-related rather than `site`-related.
   Keeping `package.html` alone would reduce the noise in the second commit, 
and it would improve the generated javadocs at the same time.
   
   ---
   
   >Does that satisfy, or are there further quibbles?
   
   Would you scan through the second commit to identify excessive changes like 
xalan/tools/xalan2jdoc.jar, serializer/tools/xalan2jdoc.jar, and so on?
   
   Try something `git diff -M --diff-filter=AR --name-status origin/master`. 
Ideally, the second commit should not contain renames (unless you rename 
classes for some reason), and it should not contain the addition of unwanted 
files (e.g. jars)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org
For additional commands, e-mail: dev-h...@xalan.apache.org

Reply via email to