kriegaex commented on PR #123: URL: https://github.com/apache/xalan-java/pull/123#issuecomment-1813765214
> First migrate. Then optimize. Well, we can leave the camp ground behind a little cleaner than we found it - boyscout rule. But as you can see in this PR, I am retaining the assemblies, merely fixing things. Not even with a clean build would it work with the new source assembly, the way you set it up. It would always include build artifacts from your non-standard `build` directory. Really, there is `target` for that, an extra directory really is not necessary. It just makes the build more complicated and slower. You are catering to Ant precedence here, which is why I had to fix something that would not have needed fixing if you would have stuck to the Maven way. You would still have been able to create your assemblies that way. > There's already more change in this than I had hoped. Do you mean in the migration branch in general or specifically in this PR? I was hoping you could merge it soon, because I solved the "taglet on JDK 9+" problem locally and have that feature branch based on this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
