kriegaex commented on PR #125: URL: https://github.com/apache/xalan-java/pull/125#issuecomment-1817730786
@kubycsolutions, please note the new optimising commit 6b80f98c. The class could be even shorter, if it was indeed intentional to return "Xalan Java" instead of something more specific like "Xalan Processor Java" in class `XSLProcessorVersion`. Was my assumption correct or wrong that it makes sense to report different product names there? I just noticed the Javacod comment in `XSLProcessorVersion`, saying `@deprecated To be replaced by org.apache.xalan.Version.getVersion()`. This would rather imply that they report identical names on purpose. When that deprecated extra class will be removed is out of scope here, so I have kept it, of course. The only open question to me is: same or different product name? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
