jkesselm commented on PR #129: URL: https://github.com/apache/xalan-java/pull/129#issuecomment-1826443355
As a sanity check, just to make sure there weren't other complications getting in the way, I tried reverting the $Version.java classes to the templated/hardcoded implementations used in the ant build. With those (and with lib/ copied back into the xalan-java directory, to satisfy xalan-test's dependencies -- see the other PR re reconstructing these until xalan-test can manage them on its own), smoketest does run cleanly. Now I'm in a position again to do a clean test of this PR. If it works, I'll merge. But we do want to remember that the templated approach is there as a fallback if this turns out to have other subtle interactions. (And, yes, I'll open a work item ontaking the bootclasspath stuff out of smoketest. But since our customers were used to having to do that dance, I think we do need to be able to tolerate running in that mode, annoying as it is, at least for one deprecation cycle. We can have the fallback write a reminder out to stderr, or something of that sort, to help folks realize they should fix it.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
