kriegaex commented on PR #129: URL: https://github.com/apache/xalan-java/pull/129#issuecomment-1829015474
> What’s the point of leaving “system classloader fallback” commit? I already explained: >> because that way we will have two working alternatives in the Git history, both with explanatory commit and code comments Moreover, we have documented the alternatives we have considered. Even better than that, we have a documented alternative, just in case in the future one of the people involved remembers this PR in a situation where we need to start from a class loader rather than from a know class. In that case, we would have to use my first strategy. > Class.getResource is anyway much better It is in this case, hence the current implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org