kriegaex opened a new pull request, #133: URL: https://github.com/apache/xalan-java/pull/133
We have a full set of parametrised unit tests as well as 3 integration tests here, all based on JUnit 5 Jupiter (and Mockito for the unit tests), despite me having a JUnit allergy. The tests are so much more tedious to write than Spock tests and still look so much uglier. I have introduced Spock to dozens of teams as an agile coach in the last 10+ years, and all of them never looked back to JUnit once they got infected and had worked with it for 2 weeks. It causes me almost physical pain to use JUnit, especially the nightmarish syntax for parametrisation. But in contrast to some other people who think it is a "waste of time" to work with a tool they dislike, I am trying to contribute something anyway. Please read the commit comments for more info or just review the changes. @jkesselm, please note that this PR was committed on top of the commit for #132, i.e. it is a super set of it. I wanted to avoid possible merge conflicts later, so my suggestion is to review #132 and possibly merge first, so I can rebase this one, or to just merge this compound PR to cover both PRs at once. If you would fast-forward instead of merge, it would be the same anyway, it only makes a difference if you create actual merge commits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org