jkesselm commented on PR #133: URL: https://github.com/apache/xalan-java/pull/133#issuecomment-1834534095
Re just replicating the version parsing code: Testing code against another copy of itself is sorta pointless. I'm not wild about Mockito's syntax, and in my experience mocking is often overused, but I don't find it unreasonable here. Discussion of future test tooling can go elsewhere (the dev list?); what's important for now is that the things proposed can still run JUnit4/Mockito tests intermixed with newer ones so there's really no need to quibble about it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
