kriegaex commented on PR #133: URL: https://github.com/apache/xalan-java/pull/133#issuecomment-1836374353
> I think the tests should either redirect `System.err` to a different stream No, not thread-safe. More important sysErr output might get suppressed, too. > or use a logger (e.g. JUL) to allow users to control the verbosity You keep repeating the same suggestions, even though I already explained elsewherewhy I am not going to do this for that little version class: Xalan-J currently does not use any logging frameworks, and I am not going to introduce one for a single class. That is way out of scope and a big decision to be made by the maintainers, not by a me. I see that you have not identified any real problems with this PR, because you focus on miniscule details. That makes me happy, because it indicated that my code is quite OK. 🙂 Thanks for all your feedback. I know you mean well. I just disagree. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
