Hello Mukul,

Please accept my apologies for the delay in starting a review.

I pulled the latest from git branch xalan-j_xslt3.0_mvn, then ran followed
these steps in the readme at
https://github.com/apache/xalan-java/blob/xalan-j_xslt3.0_mvn/README

mvn clean install -DskipTest
mvn clean test -Dtest=AllXalanXSLT3Tests

Which gave me:

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.xalan.tests.main.AllXalanXSLT3Tests
file:/Users/garygregory/git/xalan-java/./src/test/resources/fn_unparsed_text/test7.xsl;
Line #19; Column #58; Variable fileStrContents is directly or indirectly
referencing itself!
file:/Users/garygregory/git/xalan-java/./src/test/resources/fn_unparsed_text/test7.xsl;
Line #19; Column #58; Variable $fileStrContents accessed before it is
bound!.
[Fatal Error] :-1:-1: Premature end of file.
file:/Users/garygregory/git/xalan-java/./src/test/resources/fn_unparsed_text/test7.xsl;
Line #19; Column #58; Variable fileStrContents is directly or indirectly
referencing itself!
file:/Users/garygregory/git/xalan-java/./src/test/resources/fn_unparsed_text/test7.xsl;
Line #19; Column #58; Variable $fileStrContents accessed before it is
bound!.
[Fatal Error] :-1:-1: Premature end of file.
[ERROR] Tests run: 1184, Failures: 5, Errors: 0, Skipped: 0, Time elapsed:
2.722 s <<< FAILURE! - in org.apache.xalan.tests.main.AllXalanXSLT3Tests
[ERROR]
xslFnUnparsedTextTest7(org.apache.xalan.tests.xpath3.FnUnparsedTextTests)
 Time elapsed: 0.004 s  <<< FAILURE!
junit.framework.AssertionFailedError
at
org.apache.xalan.tests.xpath3.FnUnparsedTextTests.xslFnUnparsedTextTest7(FnUnparsedTextTests.java:123)

[ERROR]
xslFnUnparsedTextTest8(org.apache.xalan.tests.xpath3.FnUnparsedTextTests)
 Time elapsed: 0 s  <<< FAILURE!
junit.framework.AssertionFailedError
at
org.apache.xalan.tests.xpath3.FnUnparsedTextTests.xslFnUnparsedTextTest8(FnUnparsedTextTests.java:135)

[ERROR] xslFnTransformTest9(org.apache.xalan.tests.xpath3.FnTransformTests)
 Time elapsed: 0.002 s  <<< FAILURE!
junit.framework.AssertionFailedError
at
org.apache.xalan.tests.xpath3.FnTransformTests.xslFnTransformTest9(FnTransformTests.java:137)

[ERROR]
xslFnTransformTest11(org.apache.xalan.tests.xpath3.FnTransformTests)  Time
elapsed: 0.005 s  <<< FAILURE!
junit.framework.AssertionFailedError
at
org.apache.xalan.tests.xpath3.FnTransformTests.xslFnTransformTest11(FnTransformTests.java:157)

[ERROR]
xslFnTransformTest12(org.apache.xalan.tests.xpath3.FnTransformTests)  Time
elapsed: 0.005 s  <<< FAILURE!
junit.framework.AssertionFailedError
at
org.apache.xalan.tests.xpath3.FnTransformTests.xslFnTransformTest12(FnTransformTests.java:167)

[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR]
FnTransformTests.xslFnTransformTest11:157->XslTransformTestsUtil.runXslTransformAndAssertOutput:170
[ERROR]
FnTransformTests.xslFnTransformTest12:167->XslTransformTestsUtil.runXslTransformAndAssertOutput:170
[ERROR]
FnTransformTests.xslFnTransformTest9:137->XslTransformTestsUtil.runXslTransformAndAssertOutput:170
[ERROR]
FnUnparsedTextTests.xslFnUnparsedTextTest7:123->XslTransformTestsUtil.runXslTransformAndAssertOutputWithXslParamBaseUri:364
[ERROR]
FnUnparsedTextTests.xslFnUnparsedTextTest8:135->XslTransformTestsUtil.runXslTransformAndAssertOutputWithXslParamBaseUri:364
[INFO]
[ERROR] Tests run: 1184, Failures: 5, Errors: 0, Skipped: 0
[INFO]
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time:  6.975 s
[INFO] Finished at: 2025-07-27T10:03:10-04:00
[INFO]
------------------------------------------------------------------------

I did NOT edit:

    public static final String LOCAL_BASE_URI_PREFIX_FOR_TESTS_1 =
"file:/d:/eclipseWorkspaces/xalanj/xalan-j_xslt3.0_mvn/src/test/resources/";

    public static final String LOCAL_BASE_URI_PREFIX_FOR_TESTS_2 =
"file:/d:///eclipseWorkspaces/xalanj/xalan-j_xslt3.0_mvn/src/test/resources/";

The above is bad since a build should be able to run without a tester
editing source code.

By default, a Maven project will have it's folder "src/test/resources/" on
its classpath, so these files can be accessed either as resources or using
a relative path

Why have two Maven steps?

Why not:

mvn clean install test -Dtest=AllXalanXSLT3Tests

?

TY!
Gary


On Fri, Jul 18, 2025 at 8:50 AM Gary Gregory <[email protected]> wrote:

> I'll keep you posted here of any progress and if I need help resolving
> issue that pop up.
>
> Gary
>
> On Fri, Jul 18, 2025, 08:04 Mukul Gandhi <[email protected]> wrote:
>
>> Hi Gary,
>>     Many thanks for volunteering to try making new Xalan-J releases.
>>
>> If by any chance, I'll be committing any Xalan-J new code changes from
>> now onwards, I assure that Xalan-J's tests integrity remains the same.
>>
>> Please let us know whether, any thing from our side from Xalan-J
>> release perspective needs to be done.
>>
>> On Fri, Jul 18, 2025 at 2:20 PM Gary Gregory <[email protected]>
>> wrote:
>> >
>> > Yes, I'd be happy to help. Let me poke around this week.
>> >
>> > Gary
>> >
>> > On Thu, Jul 17, 2025, 04:00 Mukul Gandhi <[email protected]>
>> wrote:
>> >>
>> >> Hi Gary & all,
>> >>    I remember we've had discussion few weeks ago on this list, about a
>> >> possible Xalan-J XSLT 3.0 alpha or a beta release from Xalan-J's dev
>> >> repos branch xalan-j_xslt3.0_mvn.
>> >>
>> >> As of today, Xalan-J's XSLT 3.0 code base has W3C XSLT 3.0 test suite
>> >> pass % as 64.03. Xalan-J results for these XSLT tests are available
>> >> here,
>> https://github.com/apache/xalan-java/blob/xalan-j_xslt3.0_mvn/src/test/java/org/apache/xalan/tests/w3c/xslt3/result/w3c_xslt3_testsuite_xalan-j_result.xml
>> .
>> >>
>> >> Xalan-J's own XSLT 3.0 test suite has 1147 tests as of now that pass.
>> >> These are summarized within the document available here,
>> >> https://github.com/apache/xalan-java/blob/xalan-j_xslt3.0_mvn/README.
>> >>
>> >> Is it possible, we can have Xalan-J XSLT 3.0 release any time soon?
>> >> There's also an Xalan-J XSLT 1.0 release that needs to take place from
>> >> latest code base that's available on Xalan-J's dev repos branch
>> >> 'master'.
>> >>
>> >> If any of my help is needed, to make these possible new Xalan-J
>> >> releases, I'll be happy to do so.
>> >>
>> >> Any thoughts please.
>>
>>
>> --
>> Regards,
>> Mukul Gandhi
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [email protected]
>> For additional commands, e-mail: [email protected]
>>
>>

Reply via email to