Hi Gary,
Thanks for your review feedback about this work.
On Sun, Jul 27, 2025 at 7:53 PM Gary Gregory <[email protected]> wrote:
> Please accept my apologies for the delay in starting a review.
That's ok, please.
> I did NOT edit:
>
> public static final String LOCAL_BASE_URI_PREFIX_FOR_TESTS_1 =
> "file:/d:/eclipseWorkspaces/xalanj/xalan-j_xslt3.0_mvn/src/test/resources/";
>
> public static final String LOCAL_BASE_URI_PREFIX_FOR_TESTS_2 =
> "file:/d:///eclipseWorkspaces/xalanj/xalan-j_xslt3.0_mvn/src/test/resources/";
>
> The above is bad since a build should be able to run without a tester editing
> source code.
>
> By default, a Maven project will have it's folder "src/test/resources/" on
> its classpath, so these files can be accessed either as resources or using a
> relative path
>
> Why have two Maven steps?
>
> Why not:
>
> mvn clean install test -Dtest=AllXalanXSLT3Tests
I've made all these suggested changes, and have modified readme
document as well.
You may please verify the corrections I've made as per your feedback.
--
Regards,
Mukul Gandhi
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
