[
https://issues.apache.org/jira/browse/XALANJ-2651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18012699#comment-18012699
]
Joe Kesselman edited comment on XALANJ-2651 at 8/7/25 10:18 PM:
----------------------------------------------------------------
1) The intent was that the tests be usable by other XSLT projects, with the
minor effort of adding a small API adapter (which could then be included in the
test project). Those folks might not want to download all of Xalan -J just to
get the test suite. Remember that when this was written, bandwidth and storage
were larger issues than they are now.
The most obvious instance was that we wanted to be able to share the test
driver with Xalan-C, now a mostly moot point.
I don't know whether anyone else is still using our test suite. I don't know of
any really good way to find out. I'd want to at least _TRY_ to put the word out
to the XML community that we want to do that reorganization and see whether
anyone screams.
2) Arguably, if we're going to want to drive the tests from Maven, we are going
to want to do some moderately serious rework of the drivers to make them
reasonably Maven-idiomatic. In theory that shouldn't be hard – but that's what
I said about the Maven migration in the first place, and I was obviously wrong
then. Just having Maven invoke the existing batchfile isn't impossible, with
the change I submitted (Xalanj-2821), but having Maven call Ant, while not
unheard of, isn't pretty.
3) Moving to src/test/java would require some recoding in how the tests find
and invoke Xalan. Currently there's a coded assumption that either the two are
in sibling directories, or that there is a xalan-test directory directly under
xalan-java. See (2) above.
4) Make it work, make it good, make it great. In that order. We're still in
"make it work" for the Maven migration. If we keep adding changes, we'll never
complete this tasks. Let's finish commiting to Maven, *THEN* look at
reorganizing.
was (Author: JIRAUSER285361):
1) The intent was that the tests be usable by other XSLT projects, with the
minor effort of adding a small API adapter (which could then be included in the
test project). Those folks might not want to download all of Xalan -J just to
get the test suite. Remember that when this was written, bandwidth and storage
were larger issues than they are now.
The most obvious instance was that we wanted to be able to share the test
driver with Xalan-C, now a mostly moot point.
I don't know whether anyone else is still using our test suite. I don't know of
any really good way to find out. I'd want to at least _TRY_ to put the word out
to the XML community that we want to do that reorganization and see whether
anyone screams.
2) Arguably, if we're going to want to drive the tests from Maven, we are going
to want to do some moderately serious rework of the drivers to make them
reasonably Maven-idiomatic. In theory that shouldn't be hard – but that's what
I said about the Maven migration in the first place, and I was obviously wrong
then. Just having Maven invoke the existing batchfile isn't impossible, with
the change I submitted (Xalanj-2821), but having Maven call Ant, while not
unheard of, isn't pretty.
3) Moving to src/test/java would require some recoding in how the tests find
and invoke Xalan. Currently there's a coded assumption that either the two are
in sibling directories, or that there is a xalan-test directory directly under
xalan-java. See (2) above.
4) Make it work, make it good, make it great. In that order. We're still in
"make it work" for the Maven migration.
> Migrate build from Ant to Maven
> -------------------------------
>
> Key: XALANJ-2651
> URL: https://issues.apache.org/jira/browse/XALANJ-2651
> Project: XalanJ2
> Issue Type: Improvement
> Security Level: No security risk; visible to anyone(Ordinary problems in
> Xalan projects. Anybody can view the issue.)
> Components: Build
> Reporter: Gary D. Gregory
> Assignee: Joe Kesselman
> Priority: Major
>
> Migrate the build from Ant to Maven.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
