In the next patch....


> Thanks, Wesley.
> 
> StscJavaizer: the refactoring is still not done; I'll take care of it
> upon checking in
> 
> SchemaTypeCodePrinter.javaTypeForProperty: I don't understand the TODO

Removed.


> 
> SchemaTypeCodePrinter.emitGetTarget: Same comment, I don't understand
> the TODO, is this still something to be done?

Removed.

> 
> SchemaTypeCodePrinter.printGetterImpls: Same comment

Removed.


> 
> SchemaTypeCodePrinter.printSetterImpls: There is still one redundant
> "else if (prop.getJavaTypeCode() == SchemaProperty.JAVA_USER)" block
> (the second one)

I believe the one on 2439 is necessary to deal with generated "set ith
element", where the first one on line 2397 is fore setting entire arrays. I
don't see any others.


> 
> Other than that, I think we're almost there. Is there anything you
> didn't get to yet, or is this the complete change, from your point of
> view?

Still finishing the unit tests.

Wesley


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@xmlbeans.apache.org
For additional commands, e-mail: dev-h...@xmlbeans.apache.org

Reply via email to