Inline. Other than that, I think we are done, the tests look good and I like the fact that you also have a test for the array case; but I haven't run them yet.
Thanks, > > > > > SchemaTypeCodePrinter.printGetterImpls: Same comment > > Removed. > I think I still see these. I am talking about lines 2070 and 2077. If ok to remove, I'll remove them upon checking in. But I can't figure out what they mean. > > > > > SchemaTypeCodePrinter.printSetterImpls: There is still one > redundant > > "else if (prop.getJavaTypeCode() == > SchemaProperty.JAVA_USER)" block > > (the second one) > > I believe the one on 2439 is necessary to deal with generated > "set ith element", where the first one on line 2397 is fore > setting entire arrays. I don't see any others. > I am not convinced. Check the code on the final "else" branch, looks identical to me. Radu --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@xmlbeans.apache.org For additional commands, e-mail: dev-h...@xmlbeans.apache.org
