+1 (binding)
- Typically used to having RC number 2, part of the artifacts. (not
blocking)
- Verified hashes and signature
- Checked for licenses
On Mon, Nov 4, 2024 at 2:25 PM Jesus Camacho Rodriguez <jcama...@apache.org>
wrote:
> +1 (binding)
>
> Environment: Ubuntu 24.04.1, OpenJDK 11.0.24
> - Release notes: OK
> - Checksum and signature: OK
> - Source diff (release vs. Git repository): OK
> - Build from source artifacts: OK
> - Run tests: OK
>
> Minor issue (not blocking for release):
> - The link to the INFRA-684 JIRA ticket in the release notes does not point
> to the correct URL.
>
> Thanks, Vinish!
>
> -Jesús
>
>
> On Sun, Nov 3, 2024 at 5:28 PM Tim Brown <tim.brown...@gmail.com> wrote:
>
> > +1
> >
> > * Validated conversion from Iceberg, Delta, and Hudi to the other two
> > formats in a project with Java 11 and Scala 2.12
> > * Validated the Hudi Extensions are integrating into the writer path and
> > setting field IDs in the parquet files
> >
> > Thanks,
> > Tim
> >
> > On Fri, Nov 1, 2024 at 4:41 AM Stamatis Zampetakis <zabe...@apache.org>
> > wrote:
> >
> > > Ubuntu 20.04.6 LTS, JDK 11.0.8+10-LTS
> > >
> > > * Signatures and checksums OK
> > > * Release artifacts contain "apache" and "incubating" in the name OK
> > > * Diff between git repo and release artifacts matches (diff -qr
> > > apache-xtable-0.2.0-incubating incubator-xtable-git) OK
> > > * DISCLAIMER-WIP, LICENSE, NOTICE are present and correct OK
> > > * Location of the KEYS file is correct OK
> > > * README contains build instructions OK
> > > * No unexpected binary files OK (find . -type f -exec file {} \; |
> > > grep -v text)
> > > * Went over release note OK (Minor comments at the end)
> > > * All source files have ASF headers (grep -RiL "Licensed to the
> > > Apache Software Foundation") OK
> > > * Built from source artifacts and run tests (mvn clean install) OK
> > > * Built from git tag and run tests (mvn clean install) OK
> > > * Version identifier is in the expected format (0.2.0-incubating) OK
> > > * Downloaded the following jars from the maven staging repo:
> > > - xtable-api-0.2.0-incubating.jar
> > > - xtable-core_2.12-0.2.0-incubating.jar
> > > - xtable-hudi-support-extensions_2.12-0.2.0-incubating-bundled.jar
> > > - xtable-hudi-support-extensions_2.12-0.2.0-incubating.jar
> > > - xtable-hudi-support-utils-0.2.0-incubating.jar
> > > * LICENSE, NOTICE, and DISCLAIMER for the staging jars is correct and
> > > under META-INF OK
> > > * Inspected content of staging jars for 3rd party code OK (The
> > > bundled.jar contains extra code but is expected and correctly
> > > documented in META-INF/LICENSE)
> > >
> > > +1 (binding)
> > >
> > > nit: Few small remarks and suggestions for improvements:
> > > - It mentions "and binary convenience releases ..." but currently we
> > > are not publishing binary releases so we should remove the respective
> > > part from the vote template.
> > > - The duration of the vote and the voting style are not defined
> > > - The release manager can and should vote for the release; usually the
> > > RM vote is part of the initial email and is the first binding vote.
> > > - The sha512 checksum and/or the svn revision id should be present in
> > > the vote email to be able to associate the vote thread with the
> > > released artifacts and have a permanent reference
> > > - The xtable-hudi-support-extensions_2.12-0.2.0-incubating.jar that is
> > > published in the staging repo is almost empty and seems redundant; I
> > > think we should drop it from subsequent releases.
> > >
> > > Best,
> > > Stamatis
> > >
> > > On Fri, Nov 1, 2024 at 12:18 AM Vinish Reddy <vin...@apache.org>
> wrote:
> > > >
> > > > Hi everyone,
> > > >
> > > > Please review and vote on the release candidate #2 for the version
> > 0.2.0,
> > > > as follows:
> > > >
> > > > [ ] +1, Approve the release
> > > >
> > > > [ ] -1, Do not approve the release (please provide specific comments)
> > > >
> > > > The complete staging area is available for your review, which
> includes:
> > > >
> > > > *GH release notes [1],
> > > >
> > > > * the official Apache source release and binary convenience releases
> to
> > > be
> > > > deployed to dist.apache.org [2], which are signed with the key with
> > > > fingerprint 5EFD1E91 [3],
> > > >
> > > > * all artifacts to be deployed to the Maven Central Repository [4],
> > > >
> > > > * source code tag "release-0.2.0-incubating-rc2" [5],
> > > >
> > > > Thanks,
> > > > Vinish
> > > >
> > > > [1]
> > > >
> > >
> >
> https://github.com/apache/incubator-xtable/issues/551#issuecomment-2450887244
> > > >
> > > > [2]
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/xtable/0.2.0-incubating-rc2/
> > > > [2] [checksum]
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/xtable/0.2.0-incubating-rc2/apache-xtable-0.2.0-incubating.src.tgz.sha512
> > > >
> > > > [3] https://downloads.apache.org/incubator/xtable/KEYS
> > > >
> > > > [4]
> > >
> https://repository.apache.org/content/repositories/orgapachextable-1006/
> > > >
> > > > [5] [tag]
> > > >
> > >
> >
> https://github.com/apache/incubator-xtable/releases/tag/0.2.0-incubating-rc2
> > > > [5] [SHA]
> > > >
> > >
> >
> https://github.com/apache/incubator-xtable/commit/ceae10803695f44d62e106148ed8558c712542ba
> > >
> >
>
