+1 (binding) I checked: - signature and hash are correct (according to the KEYS) - incubating is in the name/version - DISCLAIMER-WIP is present in the source distribution - LICENSE and NOTICE are there, pretty minimal. I bet we should add more details in the LICENSE, not release blocker (I will do a pass for the next release) - ASF header is present (rat is OK) - No binary file found in the source distribution - Build from source distribution worked (mvn clean install)
NB: I will do a pass on LICENSE and NOTICE files for the next release Thanks ! Regards JB On Thu, Oct 31, 2024 at 11:17 PM Vinish Reddy <vin...@apache.org> wrote: > > Hi everyone, > > Please review and vote on the release candidate #2 for the version 0.2.0, > as follows: > > [ ] +1, Approve the release > > [ ] -1, Do not approve the release (please provide specific comments) > > The complete staging area is available for your review, which includes: > > *GH release notes [1], > > * the official Apache source release and binary convenience releases to be > deployed to dist.apache.org [2], which are signed with the key with > fingerprint 5EFD1E91 [3], > > * all artifacts to be deployed to the Maven Central Repository [4], > > * source code tag "release-0.2.0-incubating-rc2" [5], > > Thanks, > Vinish > > [1] > https://github.com/apache/incubator-xtable/issues/551#issuecomment-2450887244 > > [2] > https://dist.apache.org/repos/dist/dev/incubator/xtable/0.2.0-incubating-rc2/ > [2] [checksum] > https://dist.apache.org/repos/dist/dev/incubator/xtable/0.2.0-incubating-rc2/apache-xtable-0.2.0-incubating.src.tgz.sha512 > > [3] https://downloads.apache.org/incubator/xtable/KEYS > > [4] https://repository.apache.org/content/repositories/orgapachextable-1006/ > > [5] [tag] > https://github.com/apache/incubator-xtable/releases/tag/0.2.0-incubating-rc2 > [5] [SHA] > https://github.com/apache/incubator-xtable/commit/ceae10803695f44d62e106148ed8558c712542ba