+0 (binding) I checked: - OK: Signature and hash are OK, KEYS file is on the right location - NOK: DISCLAIMER-WIP is here, but it would be great to list why it's still WIP (for instance, "Contains code that may not be compatible with the Apache License" or so). Else it should be DISCLAIMER. - NOK: LICENSE is there in the source distribution, but it should mention that xtable-core/src/main/java/org/apache/xtable/hudi/HudiInstantUtils.java contains code directly copied from org.apache.hudi.common.table.timeline.HoodieActiveTimeline - OK: NOTICE is OK - OK: ASF header is present in all expected files - OK: no binary file found in the source distribution - OK: build pass from the source distribution - NOK: xtable-aws bundle jar includes a LICENSE file but AWS SDK is not documented here. NOTICE should also include AWS SDK NOTICE (as it's ALv2 dep). - NOK: xtable-hive-metastore jar includes a LICENSE file but Guava, Avro, Scala, Caffeine, RoaringBitmap, HttpClient, RocksDB, HBase, javassist are not listed (same for the NOTICE file). - NOK: xtable-hudi-support extension jar includes a LICENSE but Jackson, log4j, guava, scala, j2objc, iceberg, delta, spark-sql, caffeine, RoaringBitmap are not listed (same for the NOTICE file).
I can propose PRs to fix the NOK things. Regards JB On Thu, Apr 17, 2025 at 7:07 AM Vinish Reddy <vin...@apache.org> wrote: > > Hi everyone, > > 0.3.0-incubating rc1 blockers have been resolved. > > - https://github.com/apache/incubator-xtable/issues/692 > - https://github.com/apache/incubator-xtable/issues/693 > > Please review and vote on the release candidate #2 for the version 0.3.0, > as follows: > > [ ] +1, Approve the release > > [ ] -1, Do not approve the release (please provide specific comments) > > The complete staging area is available for your review, which includes: > > *GH release notes [1], > > * the official Apache source release and binary convenience releases to be > deployed to dist.apache.org [2], which are signed with the key with > fingerprint 5EFD1E91 [3], > > * all artifacts to be deployed to the Maven Central Repository, note that > some of these contain bundled artifacts [4] > > * source code tag "release-0.3.0-incubating-rc2" [5], > > Thanks, > Vinish > > [1] > https://github.com/apache/incubator-xtable/issues/678#issuecomment-2811743242 > > [2] > https://dist.apache.org/repos/dist/dev/incubator/xtable/0.3.0-incubating-rc2/ > [2] [checksum] > https://dist.apache.org/repos/dist/dev/incubator/xtable/0.3.0-incubating-rc2/apache-xtable-0.3.0-incubating.src.tgz.sha512 > <https://dist.apache.org/repos/dist/dev/incubator/xtable/0.3.0-incubating-rc1/apache-xtable-0.3.0-incubating.src.tgz.sha512> > > [3] https://downloads.apache.org/incubator/xtable/KEYS > > [4] https://repository.apache.org/content/repositories/orgapachextable-1011/ > > [5] [tag] > https://github.com/apache/incubator-xtable/releases/tag/0.3.0-incubating-rc2 > > [5] [SHA] > https://github.com/apache/incubator-xtable/commit/9fea75ad235914e39bc8e74e41de442e4290879d
