+1 (non-binding)

Checked: checksums/signature, incubator naming + DISCLAIMER/LICENSE/NOTICE, no 
binaries in source, license headers + RAT, source==tag, builds from 
source,staged Maven artifacts complete/signed with proper bundled L&N, and a 
functional Hudi→Iceberg conversion e2e using the staged spark-runtime bundle.

Output: https://gist.github.com/vinothchandar/452d61c64668e2a72b2f5e66d5e3a694 

Non-blocking notes (would be good to fix for the next release/RC):

1. **No single JDK builds the full source release (this may be frustrating for 
users if confirmed).** README says "Use Java 11 for  building", but 
`xtable-service` (Quarkus 3.2.12) refuses to build on JDK 11  ("Required Java 
version 17 is not met"), while on JDK 17 `xtable-api` fails in  Lombok 1.18.20 
delombok ("Cannot read field bindingsWhenTrue"). The pom comment  
`<quarkus.platform.version>3.2.12.Final <!-- compatible with Java 11 -->` and  
`mvn-ci-build.yml` (JDK 11, `./mvnw clean install`) reflect the same stale 
assumption. Workaround used above: build everything-but-service on 11, service 
on 17. Suggest upgrading Lombok (JDK-17-capable) and documenting JDK 17, or 
gating xtable-service behind a profile.
2. Source `NOTICE` copyright says 2024-2025; should include 2026 (the bundle 
jar's `NOTICE-bundled` already says 2024-2026).
3. `META-INF/LICENSE-bundled` in the spark-runtime jar lists checker-qual under 
"MIT License" but does not append the MIT license text; ASF guidance is to 
include the full text of short permissive licenses in LICENSE.
4. Observation for fellow verifiers: the shipped `.mvn/extensions.xml` enables 
the Maven build-cache extension; pass `-Dmaven.build.cache.enabled=false` when 
verifying buildability, otherwise cached restores can masquerade as a build.

On 2026/07/22 01:50:07 Vinish Reddy Pannala wrote:
> Hi everyone,
> 
> Please review and vote on the release candidate #1 for the version
> 0.4.0, as follows:
> 
> [ ] +1, Approve the release
> 
> [ ] -1, Do not approve the release (please provide specific comments)
> 
> The complete staging area is available for your review, which includes:
> 
> *GH release notes [1],
> 
> * the official Apache source release and binary convenience releases
> to be deployed to dist.apache.org [2], which are signed with the key
> with fingerprint 5EFD1E91 [3],
> 
> * all artifacts to be deployed to the Maven Central Repository, note
> that some of these contain bundled artifacts [4]
> 
> * source code tag "0.4.0-incubating-rc1" [5],
> 
> Thanks,
> Vinish
> 
> [1] 
> https://github.com/apache/incubator-xtable/issues/855#issuecomment-5040820566
> 
> [2] 
> https://dist.apache.org/repos/dist/dev/incubator/xtable/0.4.0-incubating-rc1/
> [2] [checksum] 
> https://dist.apache.org/repos/dist/dev/incubator/xtable/0.4.0-incubating-rc1/apache-xtable-0.4.0-incubating.src.tgz.sha512
> 
> [3] https://downloads.apache.org/incubator/xtable/KEYS
> 
> [4] https://repository.apache.org/content/repositories/orgapachextable-1015/
> 
> [5] [tag] 
> https://github.com/apache/incubator-xtable/releases/tag/0.4.0-incubating-rc1
> [5] [SHA] 
> https://github.com/apache/incubator-xtable/commit/6e93d25c2b0b08aeed12de80fe1851647d4c3295
> 

Reply via email to