+1 (binding) I checked: - source distribution -- incubating is in the name/version -- signature and checksum are good -- DISCLAIMER-WIP is present (maybe worth to work towards DISCLAIMER) -- LICENSE and NOTICE are good -- ASF header is present in all expected files -- No binary/compiled file in the source distribution - xtable-spark-runtime binary jar -- incubating is in the name/version -- signature and checksum are good -- LICENSE can be improved (not blocker): the LICENSE documents guava, commons-cli, snakeyaml but I don't see them bundled in the jar -- NOTICE can be improved (not blocker): it documents commons-cli, but commons-cli is not bundled in the jar. Also, it's not strictly required to include NOTICE for ASF projects (as it's already covered by "includes ASF projects"). -- META-INF contains both LICENSE and LICENSE-bundles (and NOTICE/NOTICE-bundled) but it seems to be redundant. Maybe worth to clean this up.
Thanks! Regards JB On 2026/07/22 01:50:07 Vinish Reddy Pannala wrote: > Hi everyone, > > Please review and vote on the release candidate #1 for the version > 0.4.0, as follows: > > [ ] +1, Approve the release > > [ ] -1, Do not approve the release (please provide specific comments) > > The complete staging area is available for your review, which includes: > > *GH release notes [1], > > * the official Apache source release and binary convenience releases > to be deployed to dist.apache.org [2], which are signed with the key > with fingerprint 5EFD1E91 [3], > > * all artifacts to be deployed to the Maven Central Repository, note > that some of these contain bundled artifacts [4] > > * source code tag "0.4.0-incubating-rc1" [5], > > Thanks, > Vinish > > [1] > https://github.com/apache/incubator-xtable/issues/855#issuecomment-5040820566 > > [2] > https://dist.apache.org/repos/dist/dev/incubator/xtable/0.4.0-incubating-rc1/ > [2] [checksum] > https://dist.apache.org/repos/dist/dev/incubator/xtable/0.4.0-incubating-rc1/apache-xtable-0.4.0-incubating.src.tgz.sha512 > > [3] https://downloads.apache.org/incubator/xtable/KEYS > > [4] https://repository.apache.org/content/repositories/orgapachextable-1015/ > > [5] [tag] > https://github.com/apache/incubator-xtable/releases/tag/0.4.0-incubating-rc1 > [5] [SHA] > https://github.com/apache/incubator-xtable/commit/6e93d25c2b0b08aeed12de80fe1851647d4c3295 >
