+1 and +1. I mentioned in a different thread that I consider it valuable metadata to see in the revision history who has been active reviewing specific portions of the code. This helps me identify who to notify directly if I think a code change might be risky.
--Chris Nauroth On 10/10/15, 7:20 PM, "Andrew Purtell" <[email protected]> wrote: >This sounds like something that could fit under the Yetus umbrella: >tooling that wraps/extends 'git commit' that auto-populates the lower >part of the commit message with reviewer attribution lines scraped from >JIRA and ReviewBoard. > >> On Oct 10, 2015, at 6:56 PM, Sean Busbey <[email protected]> wrote: >> >> Hey folks! >> >> I was trying to think of ways to better recognize efforts put on >> reviews today and it occurred to me that only patches from >> non-committers get a signed-off-by line today. >> >> What do folks think about adding a signed-off-by for everyone who >> provided a review (commiter or not)? >> >> I'm not exactly clear on what the logistics would be. I guess one way >> would be for the reviewer to upload an updated patch with their >> signed-off-by in place. that seems kind of heavy weight. Maybe whoever >> pushes the commit could add them? >> >> Kind of related, but maybe I should start a new thread, while >> reviewing lately I've been wondering if I could just sign-off and push >> some of the patches, even when the submitter is a committer. I'm >> thinking those that aren't labeled as a WIP or first pass or similar. >> >> -Sean >
