That'd be excellent. It would help address the wonky picture we currently get when git history is mined to figure 'contributors'. It would be a PITA and will likely fall-by-the-wayside if it is up to the committer to fill in the info. If it could be automated, filled in by a git commit-hook, that'd be sweet.
St.Ack On Sat, Oct 10, 2015 at 6:56 PM, Sean Busbey <[email protected]> wrote: > Hey folks! > > I was trying to think of ways to better recognize efforts put on > reviews today and it occurred to me that only patches from > non-committers get a signed-off-by line today. > > What do folks think about adding a signed-off-by for everyone who > provided a review (commiter or not)? > > I'm not exactly clear on what the logistics would be. I guess one way > would be for the reviewer to upload an updated patch with their > signed-off-by in place. that seems kind of heavy weight. Maybe whoever > pushes the commit could add them? > > Kind of related, but maybe I should start a new thread, while > reviewing lately I've been wondering if I could just sign-off and push > some of the patches, even when the submitter is a committer. I'm > thinking those that aren't labeled as a WIP or first pass or similar. > > -Sean >
