Hi Weiwei, Thank you for the first RC for YuniKorn.
There are some issues with the release which means that I have to give a -1 at this point. 1) NOTICE file contains a Copyright 2018-2020 message. The first commit is from 2019 so that date is not correct.The code was donated to Apache in 2020. 2) DISCLAIMER text is not correct. The project name should contain incubating, i.e. Apache Yunikorn (Incubating). The text "name of Apache TLP sponsor." should be replaced by the text " Apache Incubator PMC." 3) README.md does not state the fact that there is a pre-requisite of having a full build environment with tools installed. We need a link to the build doc at least to show where the information can be found. There are some small grammar issues also but those are minor. 4) The helm-charts directory in the root of the package points to a non existing location. The link that was created is wrong. 5) The tag that has been used is v0.8.0-incubating-rc1. That reference is in the go.mod files. That means we cannot use this source release and promote it to the real release. We cannot have a pointer to the rc1 tag in the files. I think we need to stop the vote and create a new RC to fix these issues. Wilfred On Sat, 18 Apr 2020 at 06:43, Weiwei Yang <[email protected]> wrote: > Hi all > > I'd like to call a vote for Apache YuniKorn (incubating) 0.8.0-rc1. > All release artifacts, including source code package, signatures, and > checksum, etc, can be found at: > http://people.apache.org/~wwei/apache-yunikorn-incubating-0.8.0-rc1/ > > this release has been signed with PGP > key 8D076B6491A66D7B94E94519F57176CE11856D1F, corresponding to > [email protected]. You can find the KEYS file here: > http://people.apache.org/~wwei/KEYS. > > The release has been tagged with "*v0.8.0-incubating-rc1*" in all our git > repos. > The JIRA issues have been resolved for this release can be found: > https://issues.apache.org/jira/projects/YUNIKORN/versions/12347742. > > Please review and vote. The vote will be open for at least 72 hours (that > ends on *Monday, Apr 20, 2020, 20:00 PST*). > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove (and the reason why) > > Thanks > Weiwei >
