Thanks Weiwei for addressing the comments. Only comment for below point @[email protected] <[email protected]>, this is also something I am not quite sure about. Imagine that we have our RC2 voting passed and prepare to release based on RC2, I think we need to add another tag "0.8.0-incubating" and then refresh all references in go.mod. then create another tarball with that. Is this OK?
[Sunil]: Since this require a change in source tar ball, it is like completely redoing the release artefacts again And we need to again check the packages even after getting a release +1 VOTE's. I think this may not be a good process Thanks Sunil On Tue, Apr 21, 2020 at 5:19 AM Weiwei Yang <[email protected]> wrote: > Hi Wilfred/Kinga/Sunil > > Thanks for the efforts validating it, let's fix these issues and roll out > an RC2 this week. Please see my responses below: > > > NOTICE file contains a Copyright 2018-2020 message. > Fixed. (I referred to Openwhisk: > https://github.com/apache/openwhisk/blob/master/NOTICE.txt). But I guess > it > is more appropriate to add "Incubating". > > > DISCLAIMER text is not correct. > Fixed. > > > I would extend it with changing the image pull policy as well > I don't think this is a must. Given the user will build their own docker > images, the image pull policy will be totally up to them. And it's right > below the link where they change the address, hard to miss : ) > > > the helm chart link is wrong > ah, good catch. my code refers to an absolute path on my local env (that's > how I miss it from my testing). My bad. Fixed it now. > > > for the uninstall issue in > https://issues.apache.org/jira/browse/YUNIKORN-102 > this is due to a limitation of the helm. the uninstall command works fine > for helm3.x, but for helm2, it's different. Since helm3.x is the > recommended version based on https://helm.sh/docs/intro/install/. It would > be nice for us to add some steps for helm2.x in YUNIKORN-102, but I don't > think this is a release blocker. > > > In the webUI the pending and terminated pods are shown as Running > applications. > This is a known issue, we cannot do much for this release. I suggest > planning YUNIKORN-103 <https://issues.apache.org/jira/browse/YUNIKORN-103> > for > 0.9. > > > the web UI is not working properly and the admission controller > installation is missing the yunikorn-service as well. > I have commented on YUNIKORN-104 > <https://issues.apache.org/jira/browse/YUNIKORN-104>, but I think this can > be fixed (improved) by improving our docs. > > > *"**Apache YuniKorn (incubating)"*: For consistency, we can keep > (Incubating) > Fixed > > > May be, its better to add in user-guide.md or in this README.md. > I have already pointed the user to the doc we have on github. But in > future, we might want to build docs on our web site, and point users to > there. > > > - .github folder present in k8shim, core - .gitignore present in > scheduler-interface, web, core, k8shim > @Sunil, I believe I have excluded these files in the tarball, can you > please double-check? > > > yunikorn-web Dockerfile is missing ASF license header > Created PR: https://github.com/apache/incubator-yunikorn-web/pull/30 > > One issue left for discussion is: > > 5) The tag that has been used is v0.8.0-incubating-rc1. That reference is > in the go.mod files. That means we cannot use this source release and > promote it to the real release. We cannot have a pointer to the rc1 tag in > the files. > > @[email protected] <[email protected]>, this is also something I am > not > quite sure about. Imagine that we have our RC2 voting passed and prepare to > release based on RC2, I think we need to add another tag "0.8.0-incubating" > and then refresh all references in go.mod. then create another tarball with > that. Is this OK? > > We need to put all release blockers with targetVersion=0.8, use this query > < > https://issues.apache.org/jira/browse/YUNIKORN-105?jql=project%20%3D%20YUNIKORN%20AND%20status%20in%20(Open%2C%20%22In%20Progress%22%2C%20Reopened)%20AND%20%22Target%20Version%22%20%3D%200.8 > > > to check. For now, I think the following ones need our attention > > 1. https://issues.apache.org/jira/browse/YUNIKORN-105 *[PR Available]* > 2. https://issues.apache.org/jira/browse/YUNIKORN-92 *[In Progress]* > 3. Source code tagging issue raised by Wilfred > > Please let me know if I miss anything, thanks! > > Weiwei > > > On Mon, Apr 20, 2020 at 10:16 AM Sunil Govindan <[email protected]> wrote: > > > HI Weiwei, > > > > Thanks for leading efforts in preparing this RC build. I agree to the > > points given by Wilfred and Julia above. > > I think we can call for another RC by correcting the comments. > > > > Apart from other comments above, > > > > - Basic testing seems fine. Deployed YuniKorn in my local cluster, it > went > > fine and I was able to run SPARK jobs in my K8s cluster > > - UI has come up and pages are accessible. > > > > General comments which we can fix as we are doing next RC > > 1. In README.md, > > - *"**you can find the templates in the release package `helm-charts`."* > > However the charts are assuming a repo-name called *yunikorn*. Its better > > to call out that as README.md is assuming *foo* as the repo name in > > examples. > > - *"**Apache YuniKorn (incubating)"*: For consistency, we can keep > > (Incubating) > > than (incubating) > > - May be, its better to add in user-guide.md or in this README.md. I > think > > we are missing to say what happens after we do "helm install ./yunikorn". > > We can say that under a given namespace, 2 pods ll be started. And what > > will be done by admission controller, web containers etc. > > 2. Source dirs > > - .github folder present in k8shim, core > > - .gitignore present in scheduler-interface, web, core, k8shim > > 3. License > > - yunikorn-web Dockerfile is missing ASF license header > > > > Thanks, > > Sunil > > > > On Mon, Apr 20, 2020 at 7:39 PM Julia Kinga Marton > > <[email protected]> wrote: > > > > > Hi Weiwei, > > > > > > I did some testing on the RC as well, below you can find my notes: > > > Tested the following things: > > > - verified sha512 sum: OK > > > - verified signature: OK > > > - built docker images > > > - installed Yunikorn both with Helm chart and manually > > > > > > *During the testing I found the following issues:* > > > - the helm chart link is wrong > > > - in the README.md *Run YuniKorn on an existing K8s cluster *I would > > extend > > > it with changing the image pull policy as well (It is very easy to > forget > > > about it and keep it as latest). > > > - the documentation about how to uninstall it is not complete, because > it > > > describes a one step command, however there are further steps we had to > > > perform in order to have it completely uninstalled (scale the cluster > to > > 0 > > > if we want to uninstall the admission controller as well, than we have > to > > > delete the configmap manually). Opened YUNIKORN-102 > > > <https://issues.apache.org/jira/browse/YUNIKORN-102> for fixing it. > > > - In the webUI the pending and terminated pods are show as Running > > > applications. I think this may cause misunderstandings in the future. > > > Opened YUNIKORN-103 < > https://issues.apache.org/jira/browse/YUNIKORN-103> > > > for > > > discussing and fixing this gap. > > > - In case of manual installation using scheduler.yaml > > > < > > > > > > https://github.com/apache/incubator-yunikorn-k8shim/blob/master/deployments/scheduler/scheduler.yaml > > > >descriptor > > > the web UI is not working properly and the admission controller > > > installation is missing the yunikorn-service as well. Opened > YUNIKORN-104 > > > <https://issues.apache.org/jira/browse/YUNIKORN-104> for fixing the > > > deployment descriptor. > > > > > > Regards, > > > Kinga > > > > > > > > > On Mon, Apr 20, 2020 at 6:48 AM Wilfred Spiegelenburg < > > [email protected] > > > > > > > wrote: > > > > > > > Hi Weiwei, > > > > > > > > Thank you for the first RC for YuniKorn. > > > > > > > > There are some issues with the release which means that I have to > give > > a > > > -1 > > > > at this point. > > > > > > > > 1) NOTICE file contains a Copyright 2018-2020 message. The first > commit > > > is > > > > from 2019 so that date is not correct.The code was donated to Apache > in > > > > 2020. > > > > 2) DISCLAIMER text is not correct. The project name should contain > > > > incubating, i.e. Apache Yunikorn (Incubating). > > > > The text "name of Apache TLP sponsor." should be replaced by the text > > > > " Apache Incubator PMC." > > > > 3) README.md does not state the fact that there is a pre-requisite of > > > > having a full build environment with tools installed. We need a link > to > > > the > > > > build doc at least to show where the information can be found. There > > are > > > > some small grammar issues also but those are minor. > > > > 4) The helm-charts directory in the root of the package points to a > non > > > > existing location. The link that was created is wrong. > > > > 5) The tag that has been used is v0.8.0-incubating-rc1. That > reference > > is > > > > in the go.mod files. That means we cannot use this source release and > > > > promote it to the real release. We cannot have a pointer to the rc1 > tag > > > in > > > > the files. > > > > > > > > I think we need to stop the vote and create a new RC to fix these > > issues. > > > > > > > > Wilfred > > > > > > > > On Sat, 18 Apr 2020 at 06:43, Weiwei Yang <[email protected]> wrote: > > > > > > > > > Hi all > > > > > > > > > > I'd like to call a vote for Apache YuniKorn (incubating) 0.8.0-rc1. > > > > > All release artifacts, including source code package, signatures, > and > > > > > checksum, etc, can be found at: > > > > > > http://people.apache.org/~wwei/apache-yunikorn-incubating-0.8.0-rc1/ > > > > > > > > > > this release has been signed with PGP > > > > > key 8D076B6491A66D7B94E94519F57176CE11856D1F, corresponding to > > > > > [email protected]. You can find the KEYS file here: > > > > > http://people.apache.org/~wwei/KEYS. > > > > > > > > > > The release has been tagged with "*v0.8.0-incubating-rc1*" in all > our > > > git > > > > > repos. > > > > > The JIRA issues have been resolved for this release can be found: > > > > > https://issues.apache.org/jira/projects/YUNIKORN/versions/12347742 > . > > > > > > > > > > Please review and vote. The vote will be open for at least 72 hours > > > (that > > > > > ends on *Monday, Apr 20, 2020, 20:00 PST*). > > > > > > > > > > [ ] +1 approve > > > > > [ ] +0 no opinion > > > > > [ ] -1 disapprove (and the reason why) > > > > > > > > > > Thanks > > > > > Weiwei > > > > > > > > > > > > > > >
