yangwwei commented on a change in pull request #7:
URL:
https://github.com/apache/incubator-yunikorn-release/pull/7#discussion_r437059625
##########
File path: tools/build-release.py
##########
@@ -41,19 +42,16 @@ def build_release():
release_base = os.path.join(staging_dir, release_package_name)
release_top_path = os.path.join(os.path.dirname(tools_dir),
"release-top-level-artifacts")
+ helm_chart_path = os.path.join(os.path.dirname(tools_dir),
+ "helm-charts")
Review comment:
OK, I am good with setting it to the latest.
But when we release a version, e.g next 0.9.0. Our script will copy the helm
charts to the release-dir, then our script should be able to replace `latest`
to the actual version we are going to release, i.e 0.9.0.
##########
File path: tools/build-release.py
##########
@@ -41,19 +42,16 @@ def build_release():
release_base = os.path.join(staging_dir, release_package_name)
release_top_path = os.path.join(os.path.dirname(tools_dir),
"release-top-level-artifacts")
+ helm_chart_path = os.path.join(os.path.dirname(tools_dir),
+ "helm-charts")
Review comment:
OK, I am good with setting it to the latest.
But when we release a version, e.g next 0.9.0. Our script will copy the helm
charts to the release-dir, then our script should be able to replace `latest`
to the actual version we are going to release, i.e 0.9.0. I think we have to
include the helm-charts in the release tarball because we want users to be
able. to install even without the internet connection. Does this make sense?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
