kingamarton commented on a change in pull request #7:
URL:
https://github.com/apache/incubator-yunikorn-release/pull/7#discussion_r438042198
##########
File path: tools/build-release.py
##########
@@ -41,19 +42,16 @@ def build_release():
release_base = os.path.join(staging_dir, release_package_name)
release_top_path = os.path.join(os.path.dirname(tools_dir),
"release-top-level-artifacts")
+ helm_chart_path = os.path.join(os.path.dirname(tools_dir),
+ "helm-charts")
Review comment:
I changed the version to latest to the helm charts and implemented a
version replace for the charts that will be packaged. It will pickup the
version from the config file and replace the values from values.yaml and
Chart.yaml. Also I removed the index.yaml file, since we don't need it to
master branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
