Hi Wilfred

I would like to add one more point.
Its better we use name of the files like this
*apache-yunikorn-0.9.0-incubating-src.tar.gz*
We could omit RC tag from file name.

Thanks
Sunil

On Wed, Aug 12, 2020 at 5:24 PM Wilfred Spiegelenburg <[email protected]>
wrote:

> Thank you for the update.
>
> The app CRD changes in the helm charts should not have been there. I'll
> generate a new RC and restart the vote.
>
> Thank you,
> Wilfred
>
> On Wed, 12 Aug 2020 at 09:50, Weiwei Yang <[email protected]> wrote:
>
> > Thank you @[email protected] <[email protected]> for driving this
> > release
> >
> >    - Verified DISCLAIMER, NOTICE, LICENSE, and README
> >    - Build from source, tweak the versions and registry for docker
> >    images, worked fine
> >    - Install scheduler using helm, worked fine
> >    - Run some sample workloads on a local cluster, worked fine
> >
> > A few things found in the RC1
> >
> >    - In the README file, I suggest removing the dependency requirement
> >    for the web UI build, node.js, angular CI, and yarn are only needed
> for
> >    developers. To build the docker image, they are not required
> >    - In the README file, the command "helm install ./yunikorn"  should be
> >    changed to "helm install yunikorn ./helm-charts/yunikorn" (assume
> users run
> >    this from the root dir of the build, also we need a chart name
> specified
> >    otherwise it won't work for helm3)
> >    - In the README file, the doc ref should be:
> >    https://yunikorn.apache.org/docs/
> >    - The helm chart is shipped the master version, that includes some
> >    fields that not supposed to be included in 0.9.0.
> >
> > I am -1 on this, suggest to roll an RC2 to get these issues fixed since
> > they are user-facing.
> >
> > On Mon, Aug 10, 2020 at 7:23 AM Wilfred Spiegelenburg <
> [email protected]>
> > wrote:
> >
> >> Hi all
> >>
> >>
> >> This is the first release candidate for the Apache YuniKorn (incubating)
> >> 0.9.0 release.
> >>
> >> We have resolved 130 issues. Including an extended testing framework,
> >> Travis CI, improved auto scaling support and FIFO scheduling.
> >>
> >>
> >> The release artifacts are uploaded to:
> >> https://dist.apache.org/repos/dist/dev/incubator/yunikorn/0.9.0/
> >>
> >> My public key is located here:
> >>
> >> https://dist.apache.org/repos/dist/release/incubator/yunikorn/KEYS
> >>
> >>
> >> The release has been tagged with "v0.9.0" in all our git repositories.
> >>
> >>
> >> The JIRA issues that have been resolved in this release can be found on
> >> this link
> >>
> >> https://issues.apache.org/jira/projects/YUNIKORN/versions/12347799
> >>
> >>
> >> Please review and vote. The vote will be open for at least 72 hours and
> >> closes on *Wednesday, 13 August 2020, 17:00 PST*).
> >>
> >>
> >> [ ] +1 approve
> >>
> >> [ ] +0 no opinion
> >>
> >> [ ] -1 disapprove (and the reason why)
> >>
> >>
> >> Thank you,
> >>
> >> Wilfred
> >>
> >
>

Reply via email to