+1 from my side: - checked the signature used KEYS file to check - SHA checksum confirmed - build images from source (make) - ran unit tests (make test, excluding web) - checked the docker image tags - started and ran the web interface and scheduler locally with a simple sleep job
Filed three follow up jiras to fix, neither are stoppers for the release: YUNIKORN-616: fix download instructions on the web site YUNIKORN-619: image label inconsistencies YUNIKORN-620: web make test throws errors with new chrome release Wilfred On Tue, 30 Mar 2021 at 12:00, Weiwei Yang <[email protected]> wrote: > Just checked some other projects, the issue #2 about the copyright years > should not be a release blocker. I have created > https://issues.apache.org/jira/browse/YUNIKORN-617 to track this as a > follow-up, it doesn't need to block the release. Based on this, once I can > retrieve the KEY and verify the signature, I can give +1 to this RC. > > > On Mon, Mar 29, 2021 at 2:40 PM Weiwei Yang <[email protected]> wrote: > > > Hi Tao > > > > Thank you for putting all these together. In general, it looks good, I > > have observed 2 issues though > > > > 1) Verify the Signature > > I wasn't able to verify the signature. I was following doc > > https://www.apache.org/info/verification.html. I tried to retrieve the > > key you uploaded to > > https://dist.apache.org/repos/dist/dev/incubator/yunikorn/KEYS. However, > > the command "gpg --recv-key DA341FFB8A1E3420764306AA4BC526E43B143E78" > > failed with "gpg: keyserver receive failed: No data" to me. Have you > > uploaded your KEY to the public server? See more doc: > > > https://github.com/apache/incubator-yunikorn-release/blob/master/docs/release-procedure.md#Generate-a-Key > > . > > > > 2) NOTICE file needs update > > Currently, the NOTICE file in the release tarball has the following > > context: "Copyright 2019-2020 The Apache Software Foundation". According > to > > https://www.apache.org/legal/src-headers.html#notice, we need to update > > the YEAR-YEAR to 2019-2021. > > > > other than that, I've done the following verifications and they are all > > good: > > > > 1. Verified ASF LICENSE files > > 2. Build docker images from source successfully > > 3. Verified docker image SHAs mapped to the correct commit > > 4. Install YK via helm chart shipped in the tarball > > 5. Verified basic functionality with some simple jobs > > 6. Verified gang scheduling with some simple jobs > > 7. Verified web UI and REST APIs > > > > Thanks > > > > On Sun, Mar 28, 2021 at 11:31 PM Tao Yang <[email protected]> wrote: > > > >> Hi all > >> > >> This is the first release candidate for the Apache YuniKorn (incubating) > >> 0.10.0 release. > >> > >> We have resolved 184 issues. Including gang-scheduling support, > >> application > >> lifecycle control, dependency upgrades (go 1.15 & kubernetes 1.16), > >> improvements on web UI and web-site. > >> > >> The release artifacts are uploaded to: > >> https://dist.apache.org/repos/dist/dev/incubator/yunikorn/0.10.0/ > >> > >> My public key is located here: > >> https://dist.apache.org/repos/dist/dev/incubator/yunikorn/KEYS > >> > >> The release has been tagged with "v0.10.0" in all our git repositories. > >> > >> The JIRA issues that have been resolved in this release can be found on > >> this link: > >> https://issues.apache.org/jira/projects/YUNIKORN/versions/12348351 > >> > >> Please review and vote. The vote will be open for at least 72 hours and > >> closes on *Wednesday, 31 March 2021, 22:30 PST*). > >> [ ] +1 approve > >> [ ] +0 no opinion > >> [ ] -1 disapprove (and the reason why) > >> > >> Thank you, > >> Tao > >> > > >
