hi Kinga Thank you for the comments. Could you please add some doc to https://github.com/apache/incubator-yunikorn-release/blob/master/docs/release-procedure.md to explain the steps how to publish helm charts to the artifacthub? This needs to be done once the release voting is passed. Looks like all the issues you raised up were non-source-code related. Do you want to give a +1 to the release candidate?
On Tue, Mar 30, 2021 at 5:01 AM Julia Kinga Marton <[email protected]> wrote: > Hi, > > I checked and did some tests with the RC as well: > - verified sha 512 sum > > - verified gpg > > - built the docker images > > - checked the helm charts > > - run the unit tests > > - run some examples > > > I filed some minor issues: > > - YUNIKORN-622 <https://issues.apache.org/jira/browse/YUNIKORN-622>: this > we can fix it in the next release > > - YUNIKORN-623 <https://issues.apache.org/jira/browse/YUNIKORN-623>: after > the release is out we need to update our gh-pages to have the new release > available on articathub > > - YUNIKORN-621 <https://issues.apache.org/jira/browse/YUNIKORN-621>: the > readme of the helm chart is not updated with the supported K8s versions. > The information from there is outdated. Since this information will be > published to artifacthub, I think is important to fix this one with the > proper information. What do you think? > > > > Regards, > > Kinga > > On Tue, Mar 30, 2021 at 6:26 AM Weiwei Yang <[email protected]> wrote: > > > Thank you, Tao. Just retried with the ubuntu server, it works now. > > I have verified the signature and now it looks good, add to my previous > > list: > > > > 1. Verified ASF LICENSE and NOTICE files > > 2. Build docker images from source successfully > > 3. Verified docker image SHAs mapped to the correct commit > > 4. Install YK via helm chart shipped in the tarball > > 5. Verified basic functionality with some simple jobs > > 6. Verified gang scheduling with some simple jobs > > 7. Verified web UI and REST APIs > > > > all seem good. +1 from my side. > > > > On Mon, Mar 29, 2021 at 9:08 PM Tao Yang <[email protected]> wrote: > > > > > Thanks Weiwei and Wilfred for the feedback. > > > > > > I should have sent the public key to pgp.mit.edu, which seems not > stable > > > since I often got error "gpg: keyserver receive failed: No keyserver > > > available". Thus I also sent this key to another keyserver( > > > keyserver.ubuntu.com), from which I can receive the key via command: > gpg > > > --keyserver keyserver.ubuntu.com --recv-keys 4BC526E43B143E78. > > > > > > Please have a try and let me know if this problem can be resolved. > > > > > > Thanks, > > > Tao > > > > > > Wilfred Spiegelenburg <[email protected]> 于2021年3月30日周二 上午11:53写道： > > > > > > > +1 from my side: > > > > - checked the signature used KEYS file to check > > > > - SHA checksum confirmed > > > > - build images from source (make) > > > > - ran unit tests (make test, excluding web) > > > > - checked the docker image tags > > > > - started and ran the web interface and scheduler locally with a > simple > > > > sleep job > > > > > > > > Filed three follow up jiras to fix, neither are stoppers for the > > release: > > > > YUNIKORN-616: fix download instructions on the web site > > > > YUNIKORN-619: image label inconsistencies > > > > YUNIKORN-620: web make test throws errors with new chrome release > > > > > > > > Wilfred > > > > > > > > On Tue, 30 Mar 2021 at 12:00, Weiwei Yang <[email protected]> wrote: > > > > > > > > > Just checked some other projects, the issue #2 about the copyright > > > years > > > > > should not be a release blocker. I have created > > > > > https://issues.apache.org/jira/browse/YUNIKORN-617 to track this > as > > a > > > > > follow-up, it doesn't need to block the release. Based on this, > once > > I > > > > can > > > > > retrieve the KEY and verify the signature, I can give +1 to this > RC. > > > > > > > > > > > > > > > On Mon, Mar 29, 2021 at 2:40 PM Weiwei Yang <[email protected]> > wrote: > > > > > > > > > > > Hi Tao > > > > > > > > > > > > Thank you for putting all these together. In general, it looks > > good, > > > I > > > > > > have observed 2 issues though > > > > > > > > > > > > 1) Verify the Signature > > > > > > I wasn't able to verify the signature. I was following doc > > > > > > https://www.apache.org/info/verification.html. I tried to > retrieve > > > the > > > > > > key you uploaded to > > > > > > https://dist.apache.org/repos/dist/dev/incubator/yunikorn/KEYS. > > > > However, > > > > > > the command "gpg --recv-key > > DA341FFB8A1E3420764306AA4BC526E43B143E78" > > > > > > failed with "gpg: keyserver receive failed: No data" to me. Have > > you > > > > > > uploaded your KEY to the public server? See more doc: > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/incubator-yunikorn-release/blob/master/docs/release-procedure.md#Generate-a-Key > > > > > > . > > > > > > > > > > > > 2) NOTICE file needs update > > > > > > Currently, the NOTICE file in the release tarball has the > following > > > > > > context: "Copyright 2019-2020 The Apache Software Foundation". > > > > According > > > > > to > > > > > > https://www.apache.org/legal/src-headers.html#notice, we need to > > > > update > > > > > > the YEAR-YEAR to 2019-2021. > > > > > > > > > > > > other than that, I've done the following verifications and they > are > > > all > > > > > > good: > > > > > > > > > > > > 1. Verified ASF LICENSE files > > > > > > 2. Build docker images from source successfully > > > > > > 3. Verified docker image SHAs mapped to the correct commit > > > > > > 4. Install YK via helm chart shipped in the tarball > > > > > > 5. Verified basic functionality with some simple jobs > > > > > > 6. Verified gang scheduling with some simple jobs > > > > > > 7. Verified web UI and REST APIs > > > > > > > > > > > > Thanks > > > > > > > > > > > > On Sun, Mar 28, 2021 at 11:31 PM Tao Yang <[email protected]> > > > wrote: > > > > > > > > > > > >> Hi all > > > > > >> > > > > > >> This is the first release candidate for the Apache YuniKorn > > > > (incubating) > > > > > >> 0.10.0 release. > > > > > >> > > > > > >> We have resolved 184 issues. Including gang-scheduling support, > > > > > >> application > > > > > >> lifecycle control, dependency upgrades (go 1.15 & kubernetes > > 1.16), > > > > > >> improvements on web UI and web-site. > > > > > >> > > > > > >> The release artifacts are uploaded to: > > > > > >> > https://dist.apache.org/repos/dist/dev/incubator/yunikorn/0.10.0/ > > > > > >> > > > > > >> My public key is located here: > > > > > >> https://dist.apache.org/repos/dist/dev/incubator/yunikorn/KEYS > > > > > >> > > > > > >> The release has been tagged with "v0.10.0" in all our git > > > > repositories. > > > > > >> > > > > > >> The JIRA issues that have been resolved in this release can be > > found > > > > on > > > > > >> this link: > > > > > >> > > https://issues.apache.org/jira/projects/YUNIKORN/versions/12348351 > > > > > >> > > > > > >> Please review and vote. The vote will be open for at least 72 > > hours > > > > and > > > > > >> closes on *Wednesday, 31 March 2021, 22:30 PST*). > > > > > >> [ ] +1 approve > > > > > >> [ ] +0 no opinion > > > > > >> [ ] -1 disapprove (and the reason why) > > > > > >> > > > > > >> Thank you, > > > > > >> Tao > > > > > >> > > > > > > > > > > > > > > > > > > > > >
