kingamarton commented on pull request #50: URL: https://github.com/apache/incubator-yunikorn-release/pull/50#issuecomment-977593393
> Changes look good. How has this been tested? Is there any impact on the release build code that we use to generate the helm chart? @wilfred-s I tested it manually: built the new images, installed the new charts and tried to change the configmap and checked if the validation hook is working properly, then submitted some apps without any scheuler name and checked if te mutation hook was working and the scheduler name was populated. No, it should not have any effect on the release build code, since the admission controller will be in the generated package. However this is working now, I would go forward and try to moove the admission controller part into sepparate helm chart, that way it will be completely independent from the rest of the YK deployment. Now, with this change we can update the scheduler without updating the adm. controller just by using kubectl commands. If we update it using helm commands, the admission controller will be updated as well, since it is in the same helm deployment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
