kingamarton commented on pull request #50: URL: https://github.com/apache/incubator-yunikorn-release/pull/50#issuecomment-984432012
> @kingamarton Thanks for looking into the options. Neither the pre-install hook nor init containers seem like an elegant solution. I agree with what @wilfred-s said on the need to keep the admission controller running while the scheduler is being upgraded, but I think it's still preferable to keep YuniKorn installation as a one-command procedure. Having two standalone Helm charts will be inconvenient for users. > > Now that you have refactored the admission controller into its own manifest files, is it possible to make it a [sub-chart](https://helm.sh/docs/chart_template_guide/subcharts_and_globals/) of the overall YuniKorn chart? That way, we'll have a single chart that's effectively implemented using two charts: The scheduler parent chart and the admission controller sub-chart. What do you think? Thank you @yuchaoran2011! The subcharts sound exactly what we need. I will modify the code and do some tests to make sure that it will solve our issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
