DerekTBrown commented on PR #111: URL: https://github.com/apache/yunikorn-release/pull/111#issuecomment-1283049530
> Wouldn't the real solution then be to allow changing the config map in the deployment? Combined with the current possibility of changing the yaml file you would have full control over the deployment. Both from a config map and from a yaml perspective. To summarize my understanding: As proposed in this PR: - User will create their own `ConfigMap` named `yunikorn-configs` - User will set `configuration=null` so that default `ConfigMap` is not created. As I believe you are proposing: - User will create their own `ConfigMap` named whatever they want. - User will then set something so that the YuniKorn Deployment will pull in that `ConfigMap`. - User will set something so that an extraneous `ConfigMap` is not created. My preference would be to stick with the approach proposed in this PR, as (1) it is strictly simpler than the other approach, and (2) I don't believe users need the ability to customize the `ConfigMap` name (since it is essentially irrelevant). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
