craigcondit commented on PR #111:
URL: https://github.com/apache/yunikorn-release/pull/111#issuecomment-1299455530

   @DerekTBrown, this is going to be incompatible with the configuration 
redesign that is in progress. I've updated the original JIR A you've opened, 
and have added my comments here for clarity.
   
   Please see the design doc in 
[YUNIKORN-1221](https://issues.apache.org/jira/browse/YUNIKORN-1221), which is 
our updated configuration design. Since we will be using a configmap for all 
configuration moving forward (and not just the core config), we need an 
alternative mechanism to implement disabling configmap generation.
   
   I would recommend adding a new Helm attribute:
   
   - enableConfigMap: true | false (default true for backwards compatibility)
   -- When true, ConfigMap will be generated as part of the Helm deployment (as 
it is currently).
   -- When false, no ConfigMap will be generated at all as part of Helm 
deployment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to