craigcondit commented on code in PR #128:
URL: https://github.com/apache/yunikorn-release/pull/128#discussion_r1102950591


##########
helm-charts/yunikorn/templates/ingress.yaml:
##########
@@ -14,7 +14,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-{{- if .Values.ingress.enabled -}}
+{{ if .Values.ingress.enabled }}

Review Comment:
   Please leave the leading dash to match the same pattern as others (otherwise 
an extra line is generated). Only the trailing dash should be removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to