aplufr commented on code in PR #128:
URL: https://github.com/apache/yunikorn-release/pull/128#discussion_r1102973658
##########
helm-charts/yunikorn/templates/ingress.yaml:
##########
@@ -14,7 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-{{- if .Values.ingress.enabled -}}
+{{ if .Values.ingress.enabled }}
Review Comment:
Others yaml from the helm do not have any dash on first conditional. But
indeed removing only the trailing dash is enough to fix ingress deployment and
avoid extra line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
