Wilfred Spiegelenburg created YUNIKORN-1889:
-----------------------------------------------
Summary: Remove instanceType from scheduling cycle
Key: YUNIKORN-1889
URL: https://issues.apache.org/jira/browse/YUNIKORN-1889
Project: Apache YuniKorn
Issue Type: Bug
Components: core - scheduler
Affects Versions: 1.3.0
Reporter: Wilfred Spiegelenburg
There is no need for the node instanceType in the scheduling cycle or in the
preemptor at all.
The only case in which it is used in the preemptor and that is to create a
reserved allocation. If, and when, a reserved allocation is created in the
{{TryPreemption}} we return a non nil allocation. That is the *only* time.
That non nil allocation in the end gets processed at the {{Partition}} level.
That processing gets finalised in {{partition.allocate()}}. We have a hold of
the node itself there, we should add the instance type at that point to the
allocation. That same {{partition.allocate()}} is called for all post
processing of all allocations. That means we can remove the instance type from
all scheduling calls and set it in one location.
It will indirectly also allow us to fix a bug that occurs when allocating a
reservation on a non-reserved node. That case changes the node that the
allocation is linked to and could thus change the node type.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
