[GitHub] zeppelin issue #1369: [ZEPPELIN-1376] Add proxy credentials for dependency r...

[doanduyhai]

Github user doanduyhai commented on the issue:

    https://github.com/apache/zeppelin/pull/1369
  
    @astroshim @AhyoungRyu 
    
    Ok I've found the issue, it's my bad:
    
    ```javascript
     for (var setting = 0; setting < $scope.interpreterSettings.length; 
setting++) {
            var setting = $scope.interpreterSettings[setting];
            if (setting.status === 'DOWNLOADING_DEPENDENCIES') {
              isDownloading = true;
            } else if (setting.status === 'ERROR') {
              ngToast.danger({content: 'Error setting properties for 
interpreter \'' +
                setting.group + '.' + setting.name + '\': ' + 
setting.errorReason,
                verticalPosition: 'top', dismissOnTimeout: false});
            }
          }
    ```
    
    I'm using the variable `setting` as an index for the iteration of the for 
loop as well as the variable for the setting object itself, which breaks 
awfully the for loop.
    
    Now it's fixed, see below
    
    
![fixed_errorpopup](https://cloud.githubusercontent.com/assets/1532977/18371256/bc891a6e-75e7-11e6-81e4-d3c5c2fd0498.gif)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---