GitHub user zjffdu opened a pull request:

    https://github.com/apache/zeppelin/pull/1435

    ZEPPELIN-1368. interpreter-setting.json may be loaded mutliple times

    ### What is this PR for?
    here're several ways to load interpreter-setting.json, but for now we will 
load it multiple times. It is supposed to load only once. We should load it by 
the following orders
             * 1. Register it from path 
{ZEPPELIN_HOME}/interpreter/{interpreter_name}/ interpreter-setting.json
             * 2. Register it from interpreter-setting.json in classpath 
{ZEPPELIN_HOME}/interpreter/{interpreter_name}
             * 3. Register it by Interpreter.register
    
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-1368
    
    ### How should this be tested?
    Check the log that each interpreter is registered once. And also modify 
file interpreter/spark/interpreter-setting.json to make pyspark as the default 
interpreter and it works. Before this PR, it doesn't work, because it would be 
override by interpreter-setting.json in 
`interpreter/spark/zeppelin-spark_2.10-0.7.0-SNAPSHOT.jar`
    
    ### Screenshots (if appropriate)
    
![image](https://cloud.githubusercontent.com/assets/164491/18621557/a4510966-7e57-11e6-8c9a-80697ebf2600.png)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1368

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1435.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1435
    
----
commit 8266d12d36677dd3f7ceea6356852c58bf46f8dd
Author: Jeff Zhang <zjf...@apache.org>
Date:   2016-09-19T02:47:56Z

    ZEPPELIN-1368. interpreter-setting.json may be loaded mutliple times

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to