GitHub user zjffdu opened a pull request:

    https://github.com/apache/zeppelin/pull/1440

    ZEPPELIN-1427. Scala z.show() doesn't work on v.0.6.1

    ### What is this PR for?
    `ZeppelinContext.show` doesn't work for spark 1.6. The root cause is that 
`Dataset` is also available in spark 1.6, so the following line will be false 
when cls is `Dataset` while o is `Dataframe` in spark 1.6
    ```
    if (cls.isInstance(o)) {
    ```
    This PR create a list of supported class and make it a member of 
`ZeppelinContext `so that we don't need to create it every time. 
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-1427
    
    ### How should this be tested?
    Tested it manually on spark 1.6 using the following sample code
    ```
    z.show(sqlContext.sql("show tables"))
    ```
    
    ### Screenshots (if appropriate)
    
![image](https://cloud.githubusercontent.com/assets/164491/18657995/cb25d8e8-7f31-11e6-8b26-62f39bc5587e.png)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1427

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1440.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1440
    
----
commit ef55c68f1b5b2f41a4f6a72e50bc66a995391f71
Author: Jeff Zhang <zjf...@apache.org>
Date:   2016-09-20T04:52:26Z

    ZEPPELIN-1427. Scala z.show() doesn't work on v.0.6.1

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to