GitHub user rajarajan-g reopened a pull request:

    https://github.com/apache/zeppelin/pull/1464

    [Zeppelin 796] [WIP] Duplicated notebook names should not be allowed

    ### What is this PR for?
    When a notebook is created/cloned/imported the title/name of the new 
notebook should not be duplicate of the existing notebook's title/name
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-796
    
    ### How should this be tested?
    1. Create a notebook with name 'Note', Notebook should allow user to create 
a note
    2. When a user try to create/clone/import a notebook with name 'Note', 
Notebook should not 
    allow user to create note.
    
    ### Screenshots (if appropriate)
    Screenshot of error message displayed during create/clone notebook
    
![create](https://cloud.githubusercontent.com/assets/11922701/18878102/05b401ea-84ed-11e6-92c4-539cae37c4f9.png)
    
    Screenshot of error message displayed during import notebook
    
![import](https://cloud.githubusercontent.com/assets/11922701/18878072/f69716a2-84ec-11e6-965a-3fbb29dd63d7.png)
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rajarajan-g/zeppelin ZEPPELIN-796

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1464.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1464
    
----
commit 2dec9d0b895df16c49e73b0bda5abef6457cc7bc
Author: rajarajan-g <rajarajan.gane...@imaginea.com>
Date:   2016-09-27T05:43:03Z

    Code changes for ZEPPELIN-796

commit ab04be9e0c2b6d211052a6c22c52b11a9942c866
Author: rajarajan-g <rajarajan.gane...@imaginea.com>
Date:   2016-09-27T05:52:12Z

    Removed unnecessary statements

commit 8ec520a509e3e3f1af255b6b1969aae91ad91217
Author: rajarajan-g <rajarajan.gane...@imaginea.com>
Date:   2016-09-27T06:15:38Z

    code formatted

commit 010f3e39f2162f489a34b3e34a36bdaf97425cd0
Author: rajarajan-g <rajarajan.gane...@imaginea.com>
Date:   2016-09-27T06:53:56Z

    removed unnecessary statement

commit e89090c521e7bf4a3f86eb9b42823726cd715aa1
Author: rajarajan-g <rajarajan.gane...@imaginea.com>
Date:   2016-09-27T07:26:54Z

    fix for changes

commit 2adbf7589cef4a318709b8e7ff76acd21187d9de
Author: rajarajan-g <rajarajan.gane...@imaginea.com>
Date:   2016-09-27T14:02:41Z

    code fix for Test

commit c42711fc6701acbca08d9c9423a098e74c1744fc
Author: rajarajan-g <rajarajan.gane...@imaginea.com>
Date:   2016-09-28T08:47:03Z

    custom exception

commit b24491bafa78693457687dd5da460d5e387e9ddb
Author: astroshim <hss...@nflabs.com>
Date:   2016-09-23T07:31:19Z

    [ZEPPELIN-1405] ConnectionPool for JDBCInterpreter.
    
    ### What is this PR for?
    This PR is for refactoring code for JDBCInterpreter.
    There is no putting 'Connection' to 'propertyKeyUnusedConnectionListMap' 
anywhere in the original code.
    
    ### What type of PR is it?
    Improvement
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-1405
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    
    Author: astroshim <hss...@nflabs.com>
    
    Closes #1396 from astroshim/ZEPPELIN-1405 and squashes the following 
commits:
    
    b07e162 [astroshim] add checking connection is null
    f6998c2 [astroshim] Merge branch 'master' into ZEPPELIN-1405
    1862ae6 [astroshim] Merge branch 'master' into ZEPPELIN-1405
    efc2bfc [astroshim] rebase
    21217a7 [astroshim] fix indentation.
    4d4f85c [astroshim] refactoring code of close()
    9f1e368 [astroshim] replace ConnectionPool
    4dabbcc [astroshim] wip) changing to use dbcp
    12dd7cb [astroshim] remove propertyKeyUnusedConnectionListMap map

commit e1e54b5d2435c9078d2e9122385c5a5f5e6059c7
Author: rajarajan-g <rajarajan.gane...@imaginea.com>
Date:   2016-09-28T15:12:01Z

    fixes for junit tests

commit 1307a650451226df1937109116408bad0595eb97
Author: rajarajan-g <rajarajan.gane...@imaginea.com>
Date:   2016-09-27T05:43:03Z

    Code changes for ZEPPELIN-796

commit 8911fe24509e197c6b6e4dcc65975cff047a7cef
Author: rajarajan-g <rajarajan.gane...@imaginea.com>
Date:   2016-09-27T05:52:12Z

    Removed unnecessary statements

commit 20c14eef15d09aa98c17beeb4c59db829204fcf7
Author: rajarajan-g <rajarajan.gane...@imaginea.com>
Date:   2016-09-27T06:15:38Z

    code formatted

commit cc01966bd08945741154625b68027e58c47ca5fd
Author: rajarajan-g <rajarajan.gane...@imaginea.com>
Date:   2016-09-27T06:53:56Z

    removed unnecessary statement

commit 512832f994f7802968f47e2150dc0a570e024e0e
Author: rajarajan-g <rajarajan.gane...@imaginea.com>
Date:   2016-09-27T07:26:54Z

    fix for changes

commit 66925981e9014ec2b6c05b196289e9989f0e3403
Author: rajarajan-g <rajarajan.gane...@imaginea.com>
Date:   2016-09-27T14:02:41Z

    code fix for Test

commit aba85802689bb6bab889f753bbedfb312d0c4ab1
Author: rajarajan-g <rajarajan.gane...@imaginea.com>
Date:   2016-09-28T08:47:03Z

    custom exception

commit 1a3b4c97074e8e2174182a1e236a39138f10a915
Author: rajarajan-g <rajarajan.gane...@imaginea.com>
Date:   2016-09-28T15:12:01Z

    fixes for junit tests

commit 31ab43dc2acfb2edbe5255b8f8faec30c6f353f2
Author: rajarajan-g <rajarajan.gane...@imaginea.com>
Date:   2016-09-29T05:41:15Z

    check style fix

commit f2b68e9b036462c7184ab3595c6eb73961db73ae
Author: rajarajan-g <rajarajan.gane...@imaginea.com>
Date:   2016-09-29T05:52:01Z

    fixes for checkstyle errors

commit 241be0f75f447fe3023385479636727388ddd9c4
Author: rajarajan-g <rajarajan.gane...@imaginea.com>
Date:   2016-09-29T07:17:40Z

    bug fix for Junit test

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to