GitHub user khalidhuseynov reopened a pull request:
https://github.com/apache/zeppelin/pull/1675
[ZEPPELIN-1190] Visit and switch notebook revisions
### What is this PR for?
This is to enable switching between revisions and being able to set
`Head`/current note to one of those revisions. Currently notes are editable
when switching between them, next step after this PR would be make them
non-editable during revision switches.
### What type of PR is it?
Improvement | Feature
### Todos
* [x] - routes and switching revisions
* [x] - set revision button and api
* [x] - test for setting revision
### What is the Jira issue?
[ZEPPELIN-1190](https://issues.apache.org/jira/browse/ZEPPELIN-1190)
### How should this be tested?
set config in conf/zeppelin-env.sh
```
export
ZEPPELIN_NOTEBOOK_STORAGE="org.apache.zeppelin.notebook.repo.GitNotebookRepo"
```
and switch between notes in note action bar, as well as set certain
revisions as shown below
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/incubator-zeppelin
feat/switch-revisions
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1675.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1675
----
commit 9f1c59284dd45f62fb4d984b86936a7584f68759
Author: Khalid Huseynov <[email protected]>
Date: 2016-11-24T04:59:42Z
create new root and call revision
commit 510b59ef5c2219a7b7f5f16ddf9ce0dd14f05d4f
Author: Khalid Huseynov <[email protected]>
Date: 2016-11-24T05:55:18Z
load revision note
commit d89fdefd8cfd073f773c50633036bc845091f04b
Author: Khalid Huseynov <[email protected]>
Date: 2016-11-24T06:19:56Z
visit revision when click in dropdown
commit abd666f4f25b1596f60734db8f4cc1e0b59b574d
Author: Khalid Huseynov <[email protected]>
Date: 2016-11-24T06:44:12Z
set current revision name
commit ff3dba590766dbbc20cd767041f24db4f6fb7b4e
Author: Khalid Huseynov <[email protected]>
Date: 2016-11-24T07:16:25Z
fix quotes
commit 060eb3acb7d9b96101cad58600607ca55d16038d
Author: Khalid Huseynov <[email protected]>
Date: 2016-11-24T09:49:32Z
fix getNote name change
commit c7ee3a3d6aadc8e142a2ecbf2729c6df370ea024
Author: Khalid Huseynov <[email protected]>
Date: 2016-11-25T08:29:33Z
fix pass data
commit f4477ecf7e9b6045c58181361b5adaad74f1b3fa
Author: Khalid Huseynov <[email protected]>
Date: 2016-11-27T11:02:57Z
fix parameters
commit 8d7730f85336367b1ca00469674c3456762623af
Author: Khalid Huseynov <[email protected]>
Date: 2016-11-30T03:58:30Z
add set revision button
commit 87a801b829ecf16709093997e2bf9d0b7a987403
Author: Khalid Huseynov <[email protected]>
Date: 2016-11-30T04:46:34Z
add ws api on front
commit 3a1fc372ba131a008d373d7d4a76c0dae63f0b55
Author: Khalid Huseynov <[email protected]>
Date: 2016-11-30T09:03:19Z
add backend api for setting revision
commit 655b831c586abd8c7f4c18e2dc13e550fac89bb5
Author: Khalid Huseynov <[email protected]>
Date: 2016-11-30T16:44:40Z
go to note after setting revision
commit 8a7cdf1be629f652887672fca2970b2828adb997
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-01T04:12:47Z
fix log and checkstyle
commit bd72d3216394755f04578a28b2bac3f52c6c50e0
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-01T05:19:47Z
add writer permission check
commit d93aebac977ba323431c4dd7d6d8d2de4ad81f65
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-01T09:27:46Z
return result status and reload to head if ok
commit 3998a8962a69779ea1421c7742d67c62bfc2dfb1
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-01T09:37:44Z
show error message popup if couldn't set revision
commit b47331880e696ba3f3d761db5951a1a27e392550
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-02T09:48:18Z
add test
commit b233dec350bb761bdb49324e579fa204c4a66503
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-02T10:12:24Z
add broadcast
commit 25ccf8f49aef899cf35f6f31667e4f02d210cf1c
Author: Khalid Huseynov <[email protected]>
Date: 2016-12-02T11:59:32Z
add disable flag for setting revision
only when enabled when in certain revision
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
