GitHub user khalidhuseynov reopened a pull request:

    https://github.com/apache/zeppelin/pull/1675

    [ZEPPELIN-1190] Visit and switch notebook revisions

    ### What is this PR for?
    This is to enable switching between revisions and being able to set 
`Head`/current note to one of those revisions. Currently notes are editable 
when switching between them, next step after this PR would be make them 
non-editable during revision switches. 
    
    ### What type of PR is it?
    Improvement | Feature
    
    ### Todos
    * [x] - routes and switching revisions
    * [x] - set revision button and api
    * [x] - test for setting revision
    
    ### What is the Jira issue?
    [ZEPPELIN-1190](https://issues.apache.org/jira/browse/ZEPPELIN-1190)
    
    ### How should this be tested?
    set config in conf/zeppelin-env.sh
    ```
    export 
ZEPPELIN_NOTEBOOK_STORAGE="org.apache.zeppelin.notebook.repo.GitNotebookRepo"
    ```
    and switch between notes in note action bar, as well as set certain 
revisions as shown below
    
    ### Screenshots (if appropriate)
    ![switch 
revisions](https://cloud.githubusercontent.com/assets/1642088/20833665/2b7d67d4-b8d4-11e6-95d0-0c4ae66e349d.gif)
    
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no?


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/khalidhuseynov/incubator-zeppelin 
feat/switch-revisions

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1675.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1675
    
----
commit 268fb4fbe33afaadb61879fe402d8a143c664db9
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2016-11-24T04:59:42Z

    create new root and call revision

commit ab103381571e6743ec3ae53011e38ef94aeb8449
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2016-11-24T05:55:18Z

    load revision note

commit a73214238d07f06b2f6f68fb2153c794725ba9ac
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2016-11-24T06:19:56Z

    visit revision when click in dropdown

commit d2d5396a71cddae00a422d80e2126785816e86e2
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2016-11-24T06:44:12Z

    set current revision name

commit 992a00f875c372da4ca807b0743925d09a907c7b
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2016-11-24T07:16:25Z

    fix quotes

commit 7f7b382d01a4d9f635cd25ff72346435a566a598
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2016-11-24T09:49:32Z

    fix getNote name change

commit 50469ca8c0c177c49fe63472e48d6bb38d7ce647
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2016-11-25T08:29:33Z

    fix pass data

commit 50c7a58b57b74ddfd421f315ac43ed0cb97bd93f
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2016-11-27T11:02:57Z

    fix parameters

commit 8d14981ffca40bd9ad19b4ecc7ee801c21e12591
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2016-11-30T03:58:30Z

    add set revision button

commit 7c1e300b61bb7842090db035a240ec93517d92ef
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2016-11-30T04:46:34Z

    add ws api on front

commit c7b4e73b98f7eebb0ff37793c5b7a801444632a2
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2016-11-30T09:03:19Z

    add backend api for setting revision

commit ae2cdcf6ce95d383b849f5d13384ecca0865be93
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2016-11-30T16:44:40Z

    go to note after setting revision

commit f36dc5db2f7a35d765d1d3f2786ae7ae443a69dd
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2016-12-01T04:12:47Z

    fix log and checkstyle

commit 934fb6bc62b01198f7758392f4c9bc8536c91e37
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2016-12-01T05:19:47Z

    add writer permission check

commit feb858dac287151391627a2629d02b36b9f12b13
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2016-12-01T09:27:46Z

    return result status and reload to head if ok

commit 692c6c13aa708ee19edaf3d5e215886f6646ff74
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2016-12-01T09:37:44Z

    show error message popup if couldn't set revision

commit c474ba854b23ee368c422a64139f0de852c8ca49
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2016-12-02T09:48:18Z

    add test

commit d17796bd83d95197c27bc22368fc8642dd4048ad
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2016-12-02T10:12:24Z

    add broadcast

commit 506fea08b458f44d69ccf7cbf77c39f3fb25192f
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2016-12-02T11:59:32Z

    add disable flag for setting revision
    
    only when enabled when in certain revision

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to