GitHub user 1ambda opened a pull request:

    https://github.com/apache/zeppelin/pull/2176

    [ZEPPELIN-2300] SHOULD NOT update paragraph text when local change exists

    ### What is this PR for?
    
    **SHOULD NOT** update paragraph text when local change exists
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    
    NONE
    
    ### What is the Jira issue?
    
    [ZEPPELIN-2300](https://issues.apache.org/jira/browse/ZEPPELIN-2300)
    
    Related with 
    
    - https://github.com/apache/zeppelin/pull/2120 (different approach)
    - https://issues.apache.org/jira/browse/ZEPPELIN-1492 (people are 
complaining on this issue. but different topic.)
    
    ### How should this be tested?
    
    1. Open the same note in 2 browsers (use different sessions e.g normal 
chrome + secret chrome or firefox + safari)
    2. Prepare a paragraph synchronized among sessions.
    3. Modify text in one browser. 
    4. Run the paragraph in different session.
    
    ### Screenshots (if appropriate)
    
    #### Before
    
    
![2300](https://cloud.githubusercontent.com/assets/4968473/24214869/33ddbea4-0f7a-11e7-9076-24d84bcc1618.gif)
    
    
    #### After
    
    
![after_2300](https://cloud.githubusercontent.com/assets/4968473/24214877/3703e342-0f7a-11e7-9519-1f094a110f53.gif)
    
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin 
ZEPPELIN-2300/should-not-overwrite-local-text

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2176.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2176
    
----
commit a60be33b34bb9ab3d10ee7010d6726687526dec6
Author: 1ambda <1am...@gmail.com>
Date:   2017-03-22T18:32:36Z

    fix: DON'T update paragraph.text when dirty exists

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to