felixcheung commented on a change in pull request #3179: [ZEPPELIN-3773] - add 
check permission on write.
URL: https://github.com/apache/zeppelin/pull/3179#discussion_r247304129
 
 

 ##########
 File path: zeppelin-web/src/app/notebook/notebook.controller.js
 ##########
 @@ -1200,6 +1200,31 @@ function NotebookCtrl($scope, $route, $routeParams, 
$location, $rootScope,
     return true;
   };
 
+  $scope.userHasWritePermission = function() {
+    let owners = $scope.permissions.owners;
+    let writers = $scope.permissions.writers;
+
+    if (owners.length === 0 || writers.length === 0) {
 
 Review comment:
   owners.length shouldn't be empty??

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to