Savalek commented on a change in pull request #3179: [ZEPPELIN-3773] - add
check permission on write.
URL: https://github.com/apache/zeppelin/pull/3179#discussion_r247487416
##########
File path: zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
##########
@@ -759,6 +759,9 @@ function ParagraphCtrl($scope, $rootScope, $route,
$window, $routeParams, $locat
};
$scope.sendPatch = function() {
+ if (!$scope.userHasWritePermission()) {
Review comment:
But permissions can change while the notebook is open. Or do you propose to
calculate userHasWritePermission() only when the permissions change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
