[GitHub] felixcheung commented on a change in pull request #3254: [ZEPPELIN-3575] Add 'Copy Column Name' to table visualisation-table

[GitBox]

felixcheung commented on a change in pull request #3254: [ZEPPELIN-3575] Add 
'Copy Column Name' to table visualisation-table 
URL: https://github.com/apache/zeppelin/pull/3254#discussion_r248538413
 
 

 ##########
 File path: zeppelin-web/src/app/visualization/builtins/visualization-table.js
 ##########
 @@ -256,6 +256,15 @@ export default class TableVisualization extends 
Visualization {
             return this.context.col.colDef.type === TableColumnType.DATE;
           },
         },
+        {
+          title: 'Copy Column Name',
+          action: function() {
+            self.copyStringToClipboard(this.context.col.displayName);
+          },
+          active: function() {
+            self.copyStringToClipboard(this.context.col.displayName);
 
 Review comment:
   wait, shouldn't this be true?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services