felixcheung commented on a change in pull request #3205: [ZEPPELIN-3814] Add
apply button to table settings
URL: https://github.com/apache/zeppelin/pull/3205#discussion_r248944252
##########
File path:
zeppelin-web/src/app/visualization/builtins/visualization-table-setting.html
##########
@@ -17,6 +17,12 @@
<span style="vertical-align: middle; display: inline-block; margin-top:
3px;">Table Options</span>
<span style="float: right;">
<div class="btn-group" role="group" aria-label="...">
+ <div type="button" ng-click="applyTableOption()"
+ uib-tooltip="Apply new setting" tooltip-placement="left"
+ class="btn btn-default" style="font-size: 11px;
padding: 2px 5px 2px 5px;">
+ <i class="fa fa-check-square" aria-hidden="true"></i>
Review comment:
could you clarify? I'm not suggest to change any behavior - just pop a
tooltip when one of the three option is changed, since, if I understand, any
change applies immediately. now, with your change, it would seem to the user
that "it doesn't do anything"
?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
