[GitHub] felixcheung commented on a change in pull request #3286: Fix abstractions. Removing Message class usage from NotebookService.

[GitBox]

felixcheung commented on a change in pull request #3286: Fix abstractions. 
Removing Message class usage from NotebookService.
URL: https://github.com/apache/zeppelin/pull/3286#discussion_r249566680
 
 

 ##########
 File path: 
zeppelin-server/src/main/java/org/apache/zeppelin/service/NotebookService.java
 ##########
 @@ -955,37 +952,46 @@ public void emptyTrash(ServiceContext context,
   }
 
   public void spell(String noteId,
-                    Message message,
+                    String paragraphId,
+                    String title,
+                    String text,
+                    Object results,
+                    String errorMessage,
+                    String dateStarted,
+                    String dateFinished,
+                    String status,
 
 Review comment:
   should this be typed Job.Status?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services