egorklimov commented on a change in pull request #3205: [ZEPPELIN-3814] Add apply button to table settings URL: https://github.com/apache/zeppelin/pull/3205#discussion_r249574486
########## File path: zeppelin-web/src/app/visualization/builtins/visualization-table-setting.html ########## @@ -17,6 +17,12 @@ <span style="vertical-align: middle; display: inline-block; margin-top: 3px;">Table Options</span> <span style="float: right;"> <div class="btn-group" role="group" aria-label="..."> + <div type="button" ng-click="applyTableOption()" + uib-tooltip="Apply new setting" tooltip-placement="left" + class="btn btn-default" style="font-size: 11px; padding: 2px 5px 2px 5px;"> + <i class="fa fa-check-square" aria-hidden="true"></i> Review comment: I just tried to show the new functionality, you can also just refresh the page after clicking on the checkboxes, and the changes will be applied. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services