[GitHub] maziyarpanahi commented on issue #3290: [ZEPPELIN-3939] Spark 2.4 uses a more recent commons-lang3 than Zeppelin-0.8

[GitBox]

maziyarpanahi commented on issue #3290: [ZEPPELIN-3939] Spark 2.4 uses a more 
recent commons-lang3 than Zeppelin-0.8
URL: https://github.com/apache/zeppelin/pull/3290#issuecomment-457551839
 
 
   Hi @zjffdu I have added the tests which you can see in this pull requests.
   
   Here are the results:
   
   Both tests (csv and json) have passed on 2.4, 2.3, 2.2, but failed on 1.6 
which I guess is about Scala version which I have set on 2.11:
   
   <img width="373" alt="screenshot 2019-01-25 11 49 05" 
src="https://user-images.githubusercontent.com/5762953/51744693-e926c880-20a0-11e9-93b0-f03d2a54cdbe.png";>
   <img width="376" alt="screenshot 2019-01-25 12 56 07" 
src="https://user-images.githubusercontent.com/5762953/51744694-e9bf5f00-20a0-11e9-8cb2-5dabea2151f3.png";>
   
   If I download the current release `0.8.1` with Spark 2.4 this fails:
   <img width="1040" alt="screenshot 2019-01-25 12 44 29" 
src="https://user-images.githubusercontent.com/5762953/51744739-fe035c00-20a0-11e9-9ba7-e2741f4eb92b.png";>
   
   With this pull request, it will pass:
   <img width="936" alt="screenshot 2019-01-25 11 54 18" 
src="https://user-images.githubusercontent.com/5762953/51744755-08bdf100-20a1-11e9-9c8d-da78fddc5730.png";>
   
   
   Please let me know if the tests are OK so I can also add them to the master 
with another pull request.
   
   Again, many thanks for your help. 
   I really appreciate it.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services